-
Notifications
You must be signed in to change notification settings - Fork 1.3k
create iOS download without symbols #1650
Comments
Needs some testing, but mostly followed the above scheme — two different release products:
|
Latest sizes:
Big improvement there. I think that means that we increase the size of apps by 20MB, though, in the best case, but need to confirm. |
So, significant increase but totally acceptable in both cases considering OTA apps are limited to 100MB. The end app strips during its archive process. Really this comes down to the question of whether we make the download/install process easier for devs or not, since the end app won't bloat if we leave symbols in. Either way, we should document this fact so people know what to expect in their app sizes. |
Publish process releases two packages per #1650 (comment) and we'll add both to GitHub releases, which gets linked from the binary install process directly. |
Note that we'll have to do stuff like 7bef7b3 in order to use symbols-laden builds for internal testing apps.
|
Errors caused by client code should be communicated through NSExceptions. NSAsserts are intended for internal usage; because they include helpful information like the absolute path to the file containing the assertion, stripping the build (#1650) also strips assertion messages. Also replaced hardcoded references to methods in these messages with __PRETTY_FUNCTION__, which avoids future copy-pasta and handles cases in which the MGL class has been subclassed.
Not everyone is used to a large static library (300MB+ currently) which includes symbols, since most frameworks aren't open source.
#1234, #1633
We should push dual downloads of each release, one as we do currently and one with debug symbols stripped. Maybe something like:
mapbox-gl-ios-X.Y.Z.zip
mapbox-gl-ios-symbols-X.Y.Z.zip
It's still the
Release
build configuration both ways.The text was updated successfully, but these errors were encountered: