Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Rename kReachabilityChangedNotification #1717

Closed
picciano opened this issue Jun 12, 2015 · 2 comments
Closed

Rename kReachabilityChangedNotification #1717

picciano opened this issue Jun 12, 2015 · 2 comments
Assignees
Labels
iOS Mapbox Maps SDK for iOS

Comments

@picciano
Copy link

This is a popular class to include in client apps. By including it in the libMapboxGL.a , but not including the header in the Headers directory prevents client app from using it. Also, if a client tries to include its own version of reachability, duplicate symbols build errors are the result.

@1ec5 1ec5 added the iOS Mapbox Maps SDK for iOS label Jun 12, 2015
@1ec5
Copy link
Contributor

1ec5 commented Jun 12, 2015

#759 renamed Mapbox GL’s copy of Reachability to MGLReachability, which allows the client to include their own version of Reachability without triggering duplicate symbol warnings. Reachability is a dependency of Mapbox GL but kind of out of scope for its public API.

@1ec5 1ec5 closed this as completed Jun 12, 2015
@picciano
Copy link
Author

Looks like the problem comes from this const in reachability.h:
extern NSString *const kReachabilityChangedNotification;

The workaround would either be for the client app to rename this, or rename the one in MGLReachability.

@1ec5 1ec5 reopened this Jun 12, 2015
@1ec5 1ec5 changed the title Reachability.h should be in included headers Rename kReachabilityChangedNotification Jun 12, 2015
1ec5 added a commit that referenced this issue Jun 12, 2015
@1ec5 1ec5 self-assigned this Jun 12, 2015
@1ec5 1ec5 removed the in progress label Jun 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

2 participants