Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

heading compass #243

Closed
incanus opened this issue May 23, 2014 · 4 comments
Closed

heading compass #243

incanus opened this issue May 23, 2014 · 4 comments
Labels
feature iOS Mapbox Maps SDK for iOS
Milestone

Comments

@incanus
Copy link
Contributor

incanus commented May 23, 2014

This should be part of the iOS view. It's basically already done from the SOTM demo; just need to bring it over.

@incanus incanus added this to the WWDC milestone May 23, 2014
@incanus
Copy link
Contributor Author

incanus commented May 24, 2014

Ugh, this is done feature-wise as of 10be55f but I'm hitting a GYP-ism here. @springmeyer do you have a sense of how I can accomplish the following?

  • MVKMapKit, which is a submodule, has a secondary Xcode target called Resources.

  • This target builds an MVKMapKit.bundle which contains resources images. This is a common approach, also used by our iOS SDK, to include a bunch of images/other assets without having to add them individually.

  • Back up in the iosapp GYP-generated Xcode project, I need to include said built bundle as a resource, similar to how we're doing project-level images currently:

    'mac_bundle_resources': [
        '<!@(find img -type f)'
    ],
    

The problem here is I don't have a path for the MVKMapKit.bundle as it's not yet built. It needs to be built via its non-GYP Xcode project (i.e. something like xcodebuild -project ios/MVKMapKit/MVKMapKit.xcodeproj -target Resources), then specify the result in mac_bundle_resources above.

@incanus
Copy link
Contributor Author

incanus commented May 24, 2014

I know that I could accomplish this by redoing my Resources target (and by extension probably the whole MVKMapKit sample app project) in GYP and making that a dependency of the iosapp. I'm more wondering if it's possible to invoke an external/native build system instead.

@incanus
Copy link
Contributor Author

incanus commented May 26, 2014

Interim fix:

  • As of cutting-room-floor/mapbox-gl-cocoa@16ae2ff, the MVKMapKit project (sample app and resources bundle) is created with GYP.
  • As of 9def7de, this project depends on above GYP project to build and reference the resources bundle instead of including the resources directly.

A little later in the week, after we figure out packaging of the static library, I'll figure out how to include the library, the bundle, and the headers for Cocoa devs just looking to get hacking and not work on this project directly.

@incanus
Copy link
Contributor Author

incanus commented May 26, 2014

Heading compass is done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

1 participant