Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Arrange Exceptions #2579

Closed
bleege opened this issue Oct 9, 2015 · 1 comment
Closed

Arrange Exceptions #2579

bleege opened this issue Oct 9, 2015 · 1 comment
Assignees
@bleege
Labels
Android Mapbox Maps SDK for Android
Milestone
android-v2.1.0

Comments

@bleege
Copy link
Contributor

bleege commented Oct 9, 2015

As of 01f242c the SDK has it's first custom Exception. However it's located in the com.mapbox.mapboxsdk.views package which is a bit confusing. Let's create a com.mapbox.mapboxsdk.exceptions package for custom Exception classes. This will keep things logically more organized as well as help keep the custom Exception classes from integrating too tightly with whatever is used to throw them.

This is related to #2570 and #2563.

/cc @ljbade @tobrun @zugaldia
@bleege bleege added the Android Mapbox Maps SDK for Android label Oct 9, 2015
@bleege bleege self-assigned this Oct 9, 2015
@bleege bleege added this to the android-v2.1.0 milestone Oct 9, 2015
bleege added a commit that referenced this issue Oct 9, 2015
@bleege
[android] #2579 - Removing package-info.java cruft
be5b99f
bleege added a commit that referenced this issue Oct 9, 2015
@bleege
[android] #2579 - Moving InvalidAccessTokenException to the exception…
5b65e81 
…s package
@bleege bleege mentioned this issue Oct 9, 2015
Merged
bleege added a commit that referenced this issue Oct 9, 2015
@bleege
[android] #2579 - Making constructor public so that the class can be …
69b6b12 
…used.
@ljbade
Copy link
Contributor

ljbade commented Oct 9, 2015

Good idea!

AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
@bleege
[android] mapbox#2579 - Removing package-info.java cruft
395164d
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
@bleege
[android] mapbox#2579 - Moving InvalidAccessTokenException to the exc…
3dfa1ea 
…eptions package
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
@bleege
[android] mapbox#2579 - Making constructor public so that the class c…
12a6de5 
…an be used.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bleege bleege

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v2.1.0
Development

No branches or pull requests
3 participants
@mourner @bleege @ljbade