Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Update GPS marker after renderSync #2668

Closed
ljbade opened this issue Oct 19, 2015 · 2 comments
Closed

Update GPS marker after renderSync #2668

ljbade opened this issue Oct 19, 2015 · 2 comments
Assignees
@ljbade
Labels
Android Mapbox Maps SDK for Android bug
Milestone
android-v2.2.0

Comments

@ljbade
Copy link
Contributor

ljbade commented Oct 19, 2015

While investigating why the GPS marker does not sync with the map in #2049 I notice the order we update the GPS marker and call renderSync is reversed from iOS.
@ljbade ljbade added bug Android Mapbox Maps SDK for Android labels Oct 19, 2015
@ljbade ljbade added this to the android-v2.1.0 milestone Oct 19, 2015
ljbade pushed a commit that referenced this issue Oct 19, 2015
[android] Swap GPS marker/compass update with renderSync
a9f46c0 
Fixes #2668
@ljbade ljbade self-assigned this Oct 19, 2015
@ljbade ljbade mentioned this issue Oct 19, 2015
Closed
ljbade pushed a commit that referenced this issue Oct 19, 2015
[android] Render at 60fps
0315514 
Fixes #2668
Fixes #2411
ljbade pushed a commit that referenced this issue Oct 19, 2015
[android] Render at 60fps
d592242 
Fixes #2668
Fixes #2411
@ljbade ljbade mentioned this issue Oct 19, 2015
Closed
@ljbade
Copy link
Contributor Author

ljbade commented Oct 19, 2015

Closed the original PR, implemented this as part of #2670

@ljbade ljbade modified the milestones: android-v2.2.0, android-v2.1.0 Oct 19, 2015
ljbade pushed a commit that referenced this issue Oct 20, 2015
[android] Sync GPS marker
97d193b 
Lots of other performance and memory improvements.
Fixes #2668
Fixes #2411
Fixes #2678
Fixes #2675
@ljbade ljbade mentioned this issue Oct 20, 2015
Closed
ljbade pushed a commit that referenced this issue Oct 20, 2015
[android] Sync GPS marker
bc85f93 
Lots of other performance and memory improvements.
Fixes #2668
Fixes #2411
Fixes #2678
Fixes #2675
@ljbade
Copy link
Contributor Author

ljbade commented Oct 20, 2015

I created a branch with many performance fixes including proper GPS marker sync in the 2668-render-sync branch. I can't merge until 2.1.0 is released and the release branch merged back into master.

@tobrun You might want to give the branch a test.

It still runs at 30fps however so further work will be needed.

@ljbade ljbade mentioned this issue Oct 22, 2015
Merged
ljbade pushed a commit that referenced this issue Oct 22, 2015
[android] Implement UserLocationView
8b79a8d 
Draws animated and synced GPS marker.
Inlcudes direction arrow and accuracy ring.
Fade out the compass after a delay when reset to north.
Lots of other performance and memory improvements.
add OnMyLocationChangeListener
Move FAB with snackbar
Fix getMetersPerPixelAtLatitude
Fix some incorrect annotations
Fixes #2668
Fixes #2411
Fixes #2678
Fixes #2675
Fixes #2566
Fixes #2549
Fixes #2692
Fixes #2572
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
[android] Implement UserLocationView
f64079a 
Draws animated and synced GPS marker.
Inlcudes direction arrow and accuracy ring.
Fade out the compass after a delay when reset to north.
Lots of other performance and memory improvements.
add OnMyLocationChangeListener
Move FAB with snackbar
Fix getMetersPerPixelAtLatitude
Fix some incorrect annotations
Fixes mapbox#2668
Fixes mapbox#2411
Fixes mapbox#2678
Fixes mapbox#2675
Fixes mapbox#2566
Fixes mapbox#2549
Fixes mapbox#2692
Fixes mapbox#2572
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ljbade ljbade

Labels
Android Mapbox Maps SDK for Android bug
Projects
None yet
Milestone
android-v2.2.0
Development

No branches or pull requests
1 participant
@ljbade