Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Style-driven label field #272

Closed
yhahn opened this issue May 29, 2014 · 6 comments
Closed

Style-driven label field #272

yhahn opened this issue May 29, 2014 · 6 comments
Milestone

Comments

@yhahn
Copy link
Member

yhahn commented May 29, 2014

Per voice, confirm that llmr-native is not drawing text from a hardcoded name field but can utilize other fields.

@yhahn yhahn added this to the WWDC milestone May 29, 2014
@yhahn
Copy link
Member Author

yhahn commented May 29, 2014

This is working but not for labeling contour labels (ele field) which is ... either a numeric string or not a string at all. Seeing these errors:

[WARNING] missing shaping for '3000'

Will need to dig.

@yhahn
Copy link
Member Author

yhahn commented May 29, 2014

screenshot from 2014-05-29 11 45 17

name_en for country labels.

@yhahn
Copy link
Member Author

yhahn commented May 29, 2014

^^ eliminates errors but no contour labels showing yet. Not sure if it's a style def issue or in the renderer.

@yhahn
Copy link
Member Author

yhahn commented May 29, 2014

@mikemorris is investigating the contour labels.

@mikemorris
Copy link
Contributor

@yhahn Earlier suspicions about std::u32string format were unfounded, I have no clue why these aren't rendering. Elevation labels are getting to at least https://github.com/mapbox/llmr-native/blob/master/src/renderer/text_bucket.cpp#L61 so it looks like they're actually getting pushed onto the vertex buffer, not quite sure how to debug further.

kkaefer added a commit that referenced this issue May 30, 2014
@kkaefer
Copy link
Member

kkaefer commented May 30, 2014

This turned out to be a missing style in the stylesheet. The bucket and the layer was there, but there was no associated stylesheet.

I changed the renderer so that it uses defaultProperties when it can't find a style, instead of not rendering at all.

lzq3p

@kkaefer kkaefer closed this as completed May 30, 2014
@mikemorris mikemorris removed their assignment Nov 24, 2015
acalcutt pushed a commit to acalcutt/mapbox-gl-native that referenced this issue Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants