Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Consider miniutf over boost::locale #309

Closed
1 task
springmeyer opened this issue Jun 4, 2014 · 10 comments
Closed
1 task

Consider miniutf over boost::locale #309

springmeyer opened this issue Jun 4, 2014 · 10 comments
Labels

Comments

@springmeyer
Copy link
Contributor

miniutf looks like it got its start for the same reason we fell back to using boost::locale on linux (#270): because libstdc++ is still missing full codecvt_utf8 / codecvt_utf16 support.

TODO:

@kkaefer
Copy link
Contributor

kkaefer commented Aug 15, 2014

Current case conversion support from #348 is lacking:

78r27

@kkaefer
Copy link
Contributor

kkaefer commented Aug 22, 2014

https://bitbucket.org/alekseyt/nunicode might be a better alternative than miniutf since it implements the Unicode Special Casing.

@springmeyer
Copy link
Contributor Author

Cool, had not seen nunicode before. Landing here again because I noticed that V8 has what look like depedency-free UpperCase and LowerCase routines that might be worth comparing/(and extracting?): https://github.com/v8/v8/blob/master/src/unicode.h#L221-L236

@kkaefer
Copy link
Contributor

kkaefer commented Oct 8, 2014

Sounds like a pretty good idea to do that. Likely, this has implements the same uppercase/lowercase behavior as JavaScript does, so we'd have easy parity between WebGL and native on that front.

@springmeyer
Copy link
Contributor Author

appears blink/chromium has diff uppercase impl (not sure how it relates to v8): https://github.com/yoavweiss/Blink/blob/0e22e374087693ab579b336e0a639e13f637fed1/Source/wtf/text/StringImpl.cpp#L733-L771

@artemp
Copy link
Contributor

artemp commented Nov 3, 2014

using nunicode for language aware to upper/lower conversions #530

@springmeyer
Copy link
Contributor Author

@artemp thanks for pushing on nunicode route.

  • Are there any regression tests validating the improved case conversion?
  • What do you think about my ideas above about using v8/chromium methods?

springmeyer pushed a commit that referenced this issue Nov 3, 2014
@artemp
Copy link
Contributor

artemp commented Nov 4, 2014

@springmeyer - re: blink upper/lower

  • It uses ICU and it has hardcoded locale identifiers in that method - doesn't look good to me at all.

@artemp
Copy link
Contributor

artemp commented Nov 18, 2014

Content based to_upper/lower text conversions : https://github.com/mapbox/mapbox-gl-native/tree/nunicode - but we need to wait for nunicode 1.5.x release to merge into master (ETA ~ 1 dec 2014)

@kkaefer
Copy link
Contributor

kkaefer commented Feb 27, 2015

This is merged and we're using nunicode.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants