Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

make osx builds OS X framework without Xcode, fails #3293

Closed
1ec5 opened this issue Dec 15, 2015 · 3 comments
Closed

make osx builds OS X framework without Xcode, fails #3293

1ec5 opened this issue Dec 15, 2015 · 3 comments
Assignees
Labels
build macOS Mapbox Maps SDK for macOS

Comments

@1ec5
Copy link
Contributor

1ec5 commented Dec 15, 2015

make osx attempts to build the OS X framework using make instead of xcodebuild. The framework target relies on Xcode-specific build settings, so it fails to build under make:

../../platform/osx/sdk/Mapbox.m:1:9: fatal error: 'Mapbox/Mapbox.h' file not found
#import <Mapbox/Mapbox.h>
        ^
1 error generated.

If make osx is useful in its own right, it should avoid building the framework and osxapp and limit itself to just the headless parts. Otherwise, we should remove the target because we already have make ipackage and make xosx.

/cc @brunoabinader @kkaefer

@1ec5 1ec5 added build macOS Mapbox Maps SDK for macOS labels Dec 15, 2015
@kkaefer
Copy link
Contributor

kkaefer commented Dec 15, 2015

It's fine to remove that now that we have made the pact with the devil^H^H^H use Xcode.

@1ec5
Copy link
Contributor Author

1ec5 commented Dec 15, 2015

Hey now. 😉

@brunoabinader
Copy link
Member

We're handling make linux build on OSX in #3294.

@1ec5 1ec5 mentioned this issue Dec 22, 2015
1ec5 added a commit that referenced this issue Dec 22, 2015
make osx now builds with Xcode instead of make, because building the OS X SDK and osxapp requires Xcode-specific build settings. make xosx and make nosx are now aliases to make osx.

Fixes #3293.
@1ec5 1ec5 self-assigned this Dec 22, 2015
1ec5 added a commit that referenced this issue Dec 22, 2015
make osx now builds with Xcode instead of make, because building the OS X SDK and osxapp requires Xcode-specific build settings. make xosx and make nosx are now aliases to make osx.

Fixes #3293.
@1ec5 1ec5 removed the in progress label Dec 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

3 participants