Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Update unit tests for MapboxMap #4017

Closed
tobrun opened this issue Feb 18, 2016 · 1 comment · Fixed by #4020
Closed

Update unit tests for MapboxMap #4017

tobrun opened this issue Feb 18, 2016 · 1 comment · Fixed by #4020
Assignees
@tobrun
Labels
Android Mapbox Maps SDK for Android tests
Milestone
android-v4.0.0

Comments

@tobrun
Copy link
Member

tobrun commented Feb 18, 2016

Since MapboxMap has landed with #3145. A lot of details have changed in the implementation. We should revisit the related unit test and try to improve coverage.
@tobrun tobrun added Android Mapbox Maps SDK for Android tests labels Feb 18, 2016
@tobrun tobrun added this to the android-v4.0.0 milestone Feb 18, 2016
tobrun added a commit that referenced this issue Feb 18, 2016
@tobrun
[android] #4017 - update unit test for MapboxMap
e578b60
@tobrun tobrun mentioned this issue Feb 18, 2016
Merged
@tobrun
Copy link
Member Author

tobrun commented Feb 18, 2016

Before:
screen shot 2016-02-18 at 14 10 19

After:
screen shot 2016-02-18 at 16 07 20

Notice that code coverage will increase after #4018 lands.

tobrun added a commit that referenced this issue Feb 19, 2016
@tobrun
[android] #4017 - update unit test for MapboxMap
27ed15c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android tests
Projects
None yet
Milestone
android-v4.0.0
Development

Successfully merging a pull request may close this issue.

[android] #4017 - update unit test for MapboxMap mapbox/mapbox-gl-native
2 participants
@jfirebaugh @tobrun