Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Test MGLOfflinePack and MGLOfflineStorage #4426

Closed
1ec5 opened this issue Mar 22, 2016 · 2 comments
Closed

Test MGLOfflinePack and MGLOfflineStorage #4426

1ec5 opened this issue Mar 22, 2016 · 2 comments
Assignees
@1ec5
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS tests
Milestone
ios-v3.2.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 22, 2016

We need tests for the iOS SDK’s offline functionality. The underlying mbgl classes are tested via a command-line tool, but we have nothing in this repo that specifically tests the SDK classes.

There are integration tests in a Mapbox-internal testbed application that cover an interface very similar to iosapp’s MBXOfflinePacksTableViewController. That could be a starting point, but #4287 and #4421 illustrate some difficulties in isolating MGLOfflinePack and MGLOfflineStorage for unit testing. For now, we can prebake a cache.db that contains offline packs and test the MGLOfflineStorage APIs against it.

/cc @boundsj @friedbunny
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS tests labels Mar 22, 2016
@1ec5 1ec5 mentioned this issue Mar 22, 2016
Closed
@boundsj boundsj self-assigned this Mar 22, 2016
@1ec5 1ec5 mentioned this issue Mar 27, 2016
Merged
@1ec5 1ec5 added this to the ios-v3.2.0 milestone Mar 27, 2016
@1ec5 1ec5 self-assigned this Mar 27, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Mar 27, 2016

#4482 adds functional tests for the offline SDK classes.

1ec5 added a commit that referenced this issue Mar 28, 2016
@1ec5
[osx] Offline unit tests
6ac5eb0 
Added unit tests for MGLTilePyramidOfflineRegion, MGLOfflinePack, and MGLOfflineStorage.

Fixes #4426.
@1ec5 1ec5 added the macOS Mapbox Maps SDK for macOS label Mar 28, 2016
1ec5 added a commit that referenced this issue Mar 29, 2016
@1ec5
[osx] Offline unit tests
49b4981 
Added unit tests for MGLTilePyramidOfflineRegion, MGLOfflinePack, and MGLOfflineStorage.

Fixes #4426.
1ec5 added a commit that referenced this issue Mar 29, 2016
@1ec5
[osx] Offline unit tests
b248e43 
Added unit tests for MGLTilePyramidOfflineRegion, MGLOfflinePack, and MGLOfflineStorage.

Fixes #4426.
@1ec5
Copy link
Contributor Author

1ec5 commented Mar 29, 2016

Fixed in #4482, which will be in v3.2.0-beta.3.

@1ec5 1ec5 closed this as completed Mar 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS tests
Projects
None yet
Milestone
ios-v3.2.0
Development

No branches or pull requests
2 participants
@boundsj @1ec5