Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

When map is tilted, flat annotation views should be skewed #5090

Closed
1ec5 opened this issue May 21, 2016 · 5 comments
Closed

When map is tilted, flat annotation views should be skewed #5090

1ec5 opened this issue May 21, 2016 · 5 comments
Assignees
Labels
annotations Annotations on iOS and macOS or markers on Android bug Google Maps parity For feature parity with the Google Maps SDK for Android or iOS iOS Mapbox Maps SDK for iOS
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented May 21, 2016

Both the user dot/puck and the flat annotation views introduced in #5067 rely on CATransform3DRotate() to rotate the annotation view in 3D space. But the transform is based on CATransform3DIdentity, so the annotations appear to be squashed, whereas the map is skewed with a perspective transform:

untilted
    Untilted

tilted
    Tilted

Notice how the left and right edges of each annotation remain perpendicular to the top and bottom edges, even as the north-south roads come closer together towards the top of the view. (This is the same area depicted in #1266, by the way.)

/cc @boundsj @friedbunny

@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS annotations Annotations on iOS and macOS or markers on Android labels May 21, 2016
@1ec5 1ec5 added this to the ios-v3.3.0 milestone May 21, 2016
@1ec5 1ec5 changed the title When map is tilted, flat annotation views should be skewed, not vertically scaled When map is tilted, flat annotation views should be skewed May 21, 2016
@1ec5 1ec5 self-assigned this Jun 6, 2016
1ec5 added a commit that referenced this issue Jun 6, 2016
1ec5 added a commit that referenced this issue Jun 8, 2016
1ec5 added a commit that referenced this issue Jun 24, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Jun 30, 2016

#5245 isn’t going to make iOS SDK v3.3.0, so we need to remove the flat property from MGLAnnotationView, because that property doesn’t produce the intended, documented effect. It isn’t such a big deal with the user dot/puck, which is round and relatively small, so we won’t touch that for v3.3.0. We’ll leave this bug open to track the real fix in v3.4.0.

1ec5 added a commit that referenced this issue Jul 3, 2016
Removed MGLAnnotationView’s option to lie flat against a tilted map to work around #5090.
@1ec5
Copy link
Contributor Author

1ec5 commented Jul 3, 2016

#5546 backs out the flat property, pending #5245.

@1ec5 1ec5 modified the milestones: ios-v3.3.0, ios-v3.4.0 Jul 3, 2016
1ec5 added a commit that referenced this issue Jul 10, 2016
@boundsj boundsj modified the milestones: ios-future, ios-v3.4.0 Aug 10, 2016
@1ec5 1ec5 added the Google Maps parity For feature parity with the Google Maps SDK for Android or iOS label Aug 26, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 29, 2016

The commits above are from #6686.

1ec5 added a commit that referenced this issue Jun 24, 2017
1ec5 added a commit that referenced this issue Jun 29, 2017
1ec5 added a commit that referenced this issue Jul 6, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 18, 2017

#5546 removed the flat annotation view feature, but we’re continuing to track a correct implementation of this feature in #10498.

@1ec5 1ec5 closed this as completed Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android bug Google Maps parity For feature parity with the Google Maps SDK for Android or iOS iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

2 participants