Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Javadoc for 4.1.0 release #5113

Closed
12 tasks done
tobrun opened this issue May 24, 2016 · 7 comments
Closed
12 tasks done

Javadoc for 4.1.0 release #5113

tobrun opened this issue May 24, 2016 · 7 comments
Assignees
@tobrun
Labels
Android Mapbox Maps SDK for Android documentation
Milestone
android-v4.1.0

Comments

@tobrun
Copy link
Member

tobrun commented May 24, 2016 •
edited
Loading

Ticket to track the javadoc for the 4.1.0 release:

  • MyLocationView
    • MyLocationViewSettings
    • MapboxMap API
  • View Annotations - 5113 javadoc view annotations #5168
    • MarkerViewManager
    • MarkerViewAdapter
    • MarkerViewClickListener
    • MarkerView
    • BaseMarkerViewOptions
    • MarkerViewOptions
    • MapboxMap API
  • Snapshot API
@tobrun tobrun added Android Mapbox Maps SDK for Android documentation labels May 24, 2016
@tobrun tobrun added this to the android-v4.1.0 milestone May 24, 2016
@tobrun
Copy link
Member Author

tobrun commented May 26, 2016

I'm applying the following rules & conventions when it comes to javadoc writing.

cc @bleege @zugaldia @cammace

@tobrun tobrun mentioned this issue May 27, 2016
Merged
@tobrun
Copy link
Member Author

tobrun commented May 27, 2016

First PR for javadoc landed covering everything related to view annotations in #5168

@tobrun
Copy link
Member Author

tobrun commented May 27, 2016

Looked into javadoc for the snapshot API -> 👍 -> no actions required

tobrun added a commit that referenced this issue May 27, 2016
@tobrun
[android] #5113 - added javadoc for MarkerViewManager
d54f951
tobrun added a commit that referenced this issue May 27, 2016
@tobrun
[android] #5113 - added javadoc to the MarkerView API
6cfee1d
@bleege
Copy link
Contributor

bleege commented May 27, 2016

@tobrun Remember that we need to get these PRs against the 4.1.0 Release branch now and not master as that's what is producing the daily snapshots and what we'll use to produce future 4.1.0 releases. I'll cherry pick the 2 commits from #5168 over to the release branch now.

bleege pushed a commit that referenced this issue May 27, 2016
@tobrun @bleege
[android] #5113 - added javadoc for MarkerViewManager
f75b4f1
bleege pushed a commit that referenced this issue May 27, 2016
@tobrun @bleege
[android] #5113 - added javadoc to the MarkerView API
d5cd1e1
@bleege
Copy link
Contributor

bleege commented May 27, 2016

I just completed cherry picking both commits from #5168 ( 5202effde524057a761e06805282fc2e339d3b7f and 6cfee1d) to the release-android-v4.1.0 branch.

screen shot 2016-05-27 at 10 28 30 am

@tobrun
Copy link
Member Author

tobrun commented May 27, 2016

@bleege thanks for noticing and cherry picking.

tobrun added a commit that referenced this issue May 30, 2016
@tobrun
[android] #5113 - added javadoc for MyLocationViewSettings
c66cf0f
This was referenced May 30, 2016
Closed
Merged
@tobrun tobrun self-assigned this May 31, 2016
@tobrun
Copy link
Member Author

tobrun commented May 31, 2016

I validated the last remaining item (public API on MapboxMap). It seems that checklist is done and we can close this. For later reference these PRs were used: #5189 #5168. Closing

@tobrun tobrun closed this as completed May 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android documentation
Projects
None yet
Milestone
android-v4.1.0
Development

No branches or pull requests
2 participants
@bleege @tobrun