Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Rename Objective-C++ headers back to .h #5952

Closed
1ec5 opened this issue Aug 11, 2016 · 1 comment
Closed

Rename Objective-C++ headers back to .h #5952

1ec5 opened this issue Aug 11, 2016 · 1 comment
Assignees
@1ec5
Labels
bug build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Milestone
ios-v3.4.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 11, 2016 •
edited
Loading

Xcode refuses to highlight Objective-C keywords in .hpp files. Indexing is also broken. Let’s rename the Objective-C++ headers back to .h.

/ref #5727 (comment)
/cc @frederoni
@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS build macOS Mapbox Maps SDK for macOS labels Aug 11, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 11, 2016
This was referenced Aug 11, 2016
Merged
Closed
@1ec5 1ec5 self-assigned this Aug 15, 2016
@1ec5 1ec5 mentioned this issue Aug 15, 2016
Merged
@1ec5
Copy link
Contributor Author

1ec5 commented Aug 15, 2016

In #5989, we inadvertently exposed an Objective-C++ header publicly, even though that was the problem we were trying to avoid with the .hpp extension. Given the downsides, I’m going ahead and renaming back to .h.

@1ec5 1ec5 mentioned this issue Aug 15, 2016
Merged
1ec5 added a commit that referenced this issue Aug 16, 2016
@1ec5
[ios, macos] Renamed Objective-C++ headers to .h
5539a90 
Also removed a redundant reference to MGLStyle_Private.h in ios.xcodeproj.

Fixes #5952.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
bug build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Milestone
ios-v3.4.0
Development

No branches or pull requests
1 participant
@1ec5