Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Runtime styling changes should take effect immediately #5957

Closed
1ec5 opened this issue Aug 11, 2016 · 1 comment
Closed

Runtime styling changes should take effect immediately #5957

1ec5 opened this issue Aug 11, 2016 · 1 comment
Assignees
@incanus
Labels
feature iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Milestone
ios-v3.4.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 11, 2016

Per #5727 (comment) and #5727 (comment), changes to layer and source attributes should take effect immediately. We should offer a block-based transaction API for cases in which the developer needs to change multiple attributes in tandem.

/cc @incanus @frederoni
@1ec5 1ec5 added feature iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Aug 11, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 11, 2016
@1ec5 1ec5 mentioned this issue Aug 11, 2016
Merged
25 tasks
@incanus
Copy link
Contributor

incanus commented Aug 11, 2016 •
edited
Loading

Per voice with @frederoni, the impact here is code gen to essentially call update() for each style property setter, which is verbose but, well, code gen, so not a big deal.

I'm 👍.

@1ec5 1ec5 mentioned this issue Aug 11, 2016
Closed
@incanus incanus mentioned this issue Aug 15, 2016
Merged
@1ec5 1ec5 mentioned this issue Aug 15, 2016
Closed
incanus added a commit that referenced this issue Aug 16, 2016
@incanus
fixes #5957: automatically call update() for iOS runtime style API
01b94de
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@incanus incanus

Labels
feature iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Milestone
ios-v3.4.0
Development

No branches or pull requests
3 participants
@incanus @boundsj @1ec5