Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add layers property to MGLStyle #6003

Closed
1ec5 opened this issue Aug 13, 2016 · 1 comment
Closed

Add layers property to MGLStyle #6003

1ec5 opened this issue Aug 13, 2016 · 1 comment
Assignees
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS release blocker Blocks the next final release runtime styling
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 13, 2016

MGLStyle should have a KVO-compliant layers property of type NSMutableArray. The array accessor should call a new mbgl::Map::getLayers() that calls the existing mbgl::style::Style::getLayers(). KVO provides for many getters and setters for individual items in a to-many property, such as -replaceObjectInLayersAtIndex:withObject:.

/cc @frederoni

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Aug 13, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 13, 2016
1ec5 added a commit that referenced this issue Aug 20, 2016
The property is KVO compliant with all the mutable to-many methods.

Fixes #6003.
@1ec5 1ec5 self-assigned this Aug 22, 2016
1ec5 added a commit that referenced this issue Sep 9, 2016
The property is KVO compliant with all the mutable to-many methods.

Fixes #6003.
1ec5 added a commit that referenced this issue Oct 19, 2016
The property is KVO compliant with all the mutable to-many methods.

Fixes #6003.
@boundsj boundsj added the release blocker Blocks the next final release label Oct 31, 2016
1ec5 added a commit that referenced this issue Nov 21, 2016
The property is KVO compliant with all the mutable to-many methods.

Fixes #6003.
1ec5 added a commit that referenced this issue Nov 26, 2016
Added new layers and sources properties to MGLStyle that contain all the style’s layers and sources, respectively. These properties are KVC-compliant with all the mutable to-many methods. Layers are ordered from topmost to bottommost, for consistency with Cocoa APIs where front/first means top and back/last means bottom.

Also added storage for mbgl::style::Source in MGLSource proper for wrapping AnnotationSource. Until the style finishes loading, its name property is set to nil.

Fixes #6003.
1ec5 added a commit that referenced this issue Nov 28, 2016
Added new layers and sources properties to MGLStyle that contain all the style’s layers and sources, respectively. These properties are KVC-compliant with all the mutable to-many methods. Layers are ordered from topmost to bottommost, for consistency with Cocoa APIs where front/first means top and back/last means bottom.

Also added storage for mbgl::style::Source in MGLSource proper for wrapping AnnotationSource. Until the style finishes loading, its name property is set to nil.

Fixes #6003.
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 29, 2016

Fixed in #6097.

@1ec5 1ec5 closed this as completed Nov 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS release blocker Blocks the next final release runtime styling
Projects
None yet
Development

No branches or pull requests

2 participants