This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Convert all stdout/stderr prints to use Log functions #613
Milestone
Comments
Will make a branch on master for this. |
Still need to get on to this. However I notice some more printfs have crept in, /cc @ansis |
Cool @tmpsantos that would be awesome. I found their was a mix of C++ style You will probably want to regex the repo to find them all. |
@jfirebaugh after they have been converted, we will have to make sure everyone knows not to commit code not using the |
tmpsantos
added a commit
that referenced
this issue
Mar 12, 2015
Use our logging system that will route the message accordingly on the target platform. Fixes #613
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There is still some code that writes to stdout/stderr instead of the Log functions. For example
tile_parser.cpp
This means important error messages never make it to the log on Android and makes debugging harder.
So all code using some sort of print function needs to be found and changed to Log.
Also anywhere that throws a C++ exception needs to also print a Log::Error before it throws in case we don't catch the exception and we crash instead.
The text was updated successfully, but these errors were encountered: