Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Collision detection for symbol features is broken #6628

Closed
brunoabinader opened this issue Oct 7, 2016 · 2 comments
Closed

Collision detection for symbol features is broken #6628

brunoabinader opened this issue Oct 7, 2016 · 2 comments
Labels
bug Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS

Comments

@brunoabinader
Copy link
Member

While debugging #6055, I noticed that symbol features in which placement calculation is performed - icon-ignore-placement is set to false - all features are rendered, including ones that should have been hidden due to collision with other visible features.

This is probably caused by a bug in CollisionTile implementation - which currently contains a few discrepancies from GL JS implementation - e.g. #6410 (comment).

/cc @jfirebaugh @ansis

@brunoabinader brunoabinader added bug GL JS parity For feature parity with Mapbox GL JS Core The cross-platform C++ core, aka mbgl labels Oct 7, 2016
@brunoabinader
Copy link
Member Author

Other particularity I've noticed is that this issue mostly happens when we're on a fractional zoom level - I'm attaching a unit test to this to clarify.

@brunoabinader
Copy link
Member Author

It turns out most of the issues I've perceived while debugging collision detection were caused either by symbol annotations not having a buffer on each neighbor tile to improve collision detection or duplicated collision results caused by a corner case when a symbol anchor is placed on tile edges.

This only leaves some issues related with perspective collision detection, which are handled in #6630.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

No branches or pull requests

1 participant