Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Annotation symbols should ignore icon placement #6629

Merged
merged 2 commits into from
Oct 11, 2016

Conversation

brunoabinader
Copy link
Member

We currently set icon-allow-overlap to true when creating the annotation symbol layer but we also need icon-ignore-placement set to true.

Ignoring icon placements causes symbol annotations to skip calculating the placement scale - which is currently broken (see #6628) and thus returning the correct values for rendered features.

@brunoabinader brunoabinader added bug Core The cross-platform C++ core, aka mbgl labels Oct 7, 2016
@mention-bot
Copy link

@brunoabinader, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jfirebaugh, @ansis and @boundsj to be potential reviewers.

@jfirebaugh
Copy link
Contributor

Setting setIconIgnorePlacement(true) makes sense, but can you explain the collision_tile.cpp part of this PR?

@brunoabinader
Copy link
Member Author

can you explain the collision_tile.cpp part of this PR?

In CollisionTile, features coming from layers in which placement is ignored - icon-ignore-placement: true - are inserted in the ignoredTree - which ignores placement scale - notice how placement scale is calculated only for features from the tree container.

This means these features are always visible and can bypass the placement scale check.

@brunoabinader brunoabinader force-pushed the 6629-symbol-annotation-ignore-icon-placement branch from 6e74461 to d440c56 Compare October 9, 2016 10:49
@brunoabinader
Copy link
Member Author

Addressed @jfirebaugh review comments.

@brunoabinader brunoabinader force-pushed the 6629-symbol-annotation-ignore-icon-placement branch from d440c56 to efc1bff Compare October 11, 2016 06:55
@brunoabinader brunoabinader merged commit efc1bff into master Oct 11, 2016
@brunoabinader brunoabinader deleted the 6629-symbol-annotation-ignore-icon-placement branch October 11, 2016 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants