Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Remove Guava from transitive dependencies #7129

Closed
zugaldia opened this issue Nov 21, 2016 · 6 comments
Closed

Remove Guava from transitive dependencies #7129

zugaldia opened this issue Nov 21, 2016 · 6 comments
Assignees
Labels
Android Mapbox Maps SDK for Android

Comments

@zugaldia
Copy link
Member

We're including Guava as a transitive dependency via LOST. This increases unnecessarily the method count and it doesn't affect LOST functionality if removed lostzen/lost#58. Let's add a Gradle rule to remove it explicitly.

Note that this has already been fixed in LOST 2.0 #6537 and won't be necessary once we upgrade.

/cc: @cammace @tobrun

@zugaldia zugaldia added the Android Mapbox Maps SDK for Android label Nov 21, 2016
@zugaldia zugaldia added this to the android-v4.2.0 milestone Nov 21, 2016
@zugaldia zugaldia self-assigned this Nov 21, 2016
@zugaldia
Copy link
Member Author

cc: @Guardiola31337

@zugaldia
Copy link
Member Author

Fixed via #7135.

@niedzielski
Copy link
Contributor

@zugaldia, o/ I believe this fix was slated for v4.2.2 but I'm still seeing Guava as a dependency when specifying the v4.2.2 respository aar dependency instead of the project. For example, in the MapboxGLAndroidSDKTestApp app, gradlew :MapboxGLAndroidSDKTestApp:dependencies shows no Mapzen dependency on Guava. However, change the dependency:

    // comment out project
    // compile(project(':MapboxGLAndroidSDK')) {
    //     transitive = true
    // }

    // add aar dependency from repository
    compile('com.mapbox.mapboxsdk:mapbox-android-sdk:4.2.2@aar') {
        transitive = true
    }

And now Mapzen depends on com.google.guava:guava:18.0. Can we reopen this issue?

@zugaldia
Copy link
Member Author

@niedzielski Thanks for the report. Could you check 5.0.0-beta.1 released today #8051? We've finally upgraded to LOST 2.0.0 which only includes Guava as a test dependency.

@niedzielski
Copy link
Contributor

@zugaldia, cool! v5.0.0-beta.1 appears to be correct. Thanks :]

@zugaldia
Copy link
Member Author

@niedzielski thanks for the 👀 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

2 participants