This repository was archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove Guava from transitive dependencies #7129
Comments
cc: @Guardiola31337 |
zugaldia
added a commit
that referenced
this issue
Nov 21, 2016
zugaldia
added a commit
that referenced
this issue
Nov 21, 2016
Fixed via #7135. |
@zugaldia, o/ I believe this fix was slated for v4.2.2 but I'm still seeing Guava as a dependency when specifying the v4.2.2 respository aar dependency instead of the project. For example, in the MapboxGLAndroidSDKTestApp app, // comment out project
// compile(project(':MapboxGLAndroidSDK')) {
// transitive = true
// }
// add aar dependency from repository
compile('com.mapbox.mapboxsdk:mapbox-android-sdk:4.2.2@aar') {
transitive = true
} And now Mapzen depends on |
@niedzielski Thanks for the report. Could you check |
@zugaldia, cool! v5.0.0-beta.1 appears to be correct. Thanks :] |
@niedzielski thanks for the 👀 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We're including Guava as a transitive dependency via LOST. This increases unnecessarily the method count and it doesn't affect LOST functionality if removed lostzen/lost#58. Let's add a Gradle rule to remove it explicitly.
Note that this has already been fixed in LOST 2.0 #6537 and won't be necessary once we upgrade.
/cc: @cammace @tobrun
The text was updated successfully, but these errors were encountered: