Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Cached shader loader keeps reading garbage #740

Closed
ljbade opened this issue Jan 7, 2015 · 1 comment · Fixed by #745
Closed

Cached shader loader keeps reading garbage #740

ljbade opened this issue Jan 7, 2015 · 1 comment · Fixed by #745
Labels
Android Mapbox Maps SDK for Android

Comments

@ljbade
Copy link
Contributor

ljbade commented Jan 7, 2015

For some reason the cached GL program binary loader keeps reading garbage from the cache file. I have added some checks to stop this crashing the app, but I need to figure out why it is reading garbage in the first place.

The relevant code is fairly simple C++ iostreams code so I don't see why it is going crazy. See https://github.com/mapbox/mapbox-gl-native/blob/master/src/mbgl/shader/shader.cpp#L28-L37
@ljbade ljbade added the Android Mapbox Maps SDK for Android label Jan 7, 2015
@ljbade ljbade mentioned this issue Jan 9, 2015
Closed
@ljbade ljbade added the Linux label Jan 12, 2015
@ljbade
Copy link
Contributor Author

ljbade commented Jan 12, 2015

OK discovered this issue also occurs on Linux.

@ljbade ljbade mentioned this issue Jan 12, 2015
Merged
ljbade pushed a commit that referenced this issue Jan 13, 2015
Check for IO errors when loading binary shader. Fixes #740
8cca0a2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for IO errors when loading binary shader mapbox/mapbox-gl-native
1 participant
@ljbade