Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

re-enable CocoaPods support #829

Closed
incanus opened this issue Feb 10, 2015 · 7 comments · Fixed by #1030
Closed

re-enable CocoaPods support #829

incanus opened this issue Feb 10, 2015 · 7 comments · Fixed by #1030
Assignees
@1ec5
Labels
build iOS Mapbox Maps SDK for iOS
Milestone
iOS Beta 1

Comments

@incanus
Copy link
Contributor

incanus commented Feb 10, 2015

Carryover from #824. We should install MapboxGL.framework when CocoaPods 0.36.0 lands. Depends on #828.
@incanus incanus added iOS Mapbox Maps SDK for iOS build labels Feb 10, 2015
@incanus incanus self-assigned this Feb 10, 2015
@incanus incanus modified the milestone: iOS Beta Feb 13, 2015
@incanus incanus mentioned this issue Mar 13, 2015
Closed
@1ec5
Copy link
Contributor

1ec5 commented Mar 13, 2015

Framework support has been moved to #828. We’re just looking at distributing a static library via CocoaPods for this ticket.

@incanus
Copy link
Contributor Author

incanus commented Mar 13, 2015

Yep, we'll eventually distribute both, I think? Not sure offhand how CocoaPods 0.36.0 (which just went stable) handles this.

@1ec5
Copy link
Contributor

1ec5 commented Mar 13, 2015

I’d prefer to eventually move towards only distributing a framework, because that makes asset distribution easier, and because niceties like inspectables and designables are only possible with frameworks.

@incanus
Copy link
Contributor Author

incanus commented Mar 13, 2015

But then don't we drop iOS 7?

@1ec5
Copy link
Contributor

1ec5 commented Mar 13, 2015

Yeah, I meant eventually as in someday, when we’re comfortable with dropping iOS 7.

@incanus
Copy link
Contributor Author

incanus commented Mar 13, 2015 via email

@incanus incanus mentioned this issue Mar 16, 2015
Closed
@1ec5 1ec5 mentioned this issue Mar 16, 2015
Merged
@incanus incanus assigned 1ec5 and unassigned incanus Mar 18, 2015
1ec5 added a commit that referenced this issue Mar 19, 2015
@1ec5
Prepared podspec for beta 1
1be8e63 
This podspec was originally lifted from mapbox/mapbox-ios-sdk, which was structured and built quite differently. We could have the podspec build this repo as is, using scripts/package_ios.sh, but that would require developers to install the same version of Xcode as Travis is using (see #977). So this podspec instead pulls a prebuilt library. Much simpler.

Also package a LICENSE with the archive to satisfy a CocoaPods warning.

Fixes #829.
@1ec5 1ec5 mentioned this issue Mar 19, 2015
Merged
@1ec5
Copy link
Contributor

1ec5 commented Mar 20, 2015

This pod depends on a prebuilt binary due to #977 (comment). See “Releasing Mapbox GL for iOS” for release instructions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
build iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
iOS Beta 1
Development

Successfully merging a pull request may close this issue.

CocoaPod podspec for beta 1 mapbox/mapbox-gl-native
2 participants
@incanus @1ec5