Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Don't redoPlacement for zoom changes on low-pitch maps #9996

Closed
ChrisLoer opened this issue Sep 14, 2017 · 1 comment
Closed

Don't redoPlacement for zoom changes on low-pitch maps #9996

ChrisLoer opened this issue Sep 14, 2017 · 1 comment
Assignees
@ChrisLoer
Labels
GL JS parity For feature parity with Mapbox GL JS

Comments

@ChrisLoer
Copy link
Contributor

This is a port of mapbox/mapbox-gl-js#5284. The corresponding change in gl-native would be in the equality operator of PlacementConfig.

@jfirebaugh, do you have a read on whether this is likely to be more or less of a performance issue on native than GL JS?
@ChrisLoer ChrisLoer added the GL JS parity For feature parity with Mapbox GL JS label Sep 14, 2017
@ChrisLoer ChrisLoer self-assigned this Sep 14, 2017
ChrisLoer added a commit that referenced this issue Sep 14, 2017
@ChrisLoer
[core] Don't redo placement for zoom changes at low pitch.
8aa47e5 
 Fixes issue #9996
 Port of GL-JS #5284
@ChrisLoer ChrisLoer mentioned this issue Sep 14, 2017
Merged
ChrisLoer added a commit that referenced this issue Sep 18, 2017
@ChrisLoer
[core] Don't redo placement for zoom changes at low pitch.
975d6b1 
 Fixes issue #9996
 Port of GL-JS #5284
@ChrisLoer
Copy link
Contributor Author

Fixed in #10002

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChrisLoer ChrisLoer

Labels
GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisLoer