Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Testapp cleanup #10006

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Testapp cleanup #10006

merged 1 commit into from
Sep 18, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Sep 15, 2017

  • move strings resources to dedicated files
  • fixup simple map activity
  • fixup double map activity
  • snapshot activity home button click fix
  • add activity titles,
  • remove obsolete navigation drawer activity

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Sep 15, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Sep 15, 2017
@tobrun tobrun self-assigned this Sep 15, 2017
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup 👏
Good job!

@@ -18,6 +18,9 @@
import com.mapbox.mapboxsdk.testapp.model.annotations.CityStateMarkerOptions;
import com.mapbox.mapboxsdk.testapp.utils.IconUtils;

/**
* Test activity showcasing using in InfoWindowAdapter to provide a custom InfoWindow content.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT typo *in should be an.

@@ -23,6 +22,12 @@
import com.mapbox.mapboxsdk.maps.UiSettings;
import com.mapbox.mapboxsdk.testapp.R;

/**
* Test activity showcasing showing 2 maps on top of each other.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT showcasing showing sounds strange to me.

…ap activity, fixup double map activity, snapshot activity home button click fix, add activity titles, remove obsolete navigation drawer activity
@tobrun tobrun merged commit 00dde25 into master Sep 18, 2017
@tobrun tobrun deleted the tvn-testapp-fixes branch September 18, 2017 13:56
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 6, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
21 tasks
This was referenced Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants