Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios, macos] Improve snap shotter documentation. #10020

Merged
merged 11 commits into from
Oct 4, 2017
Merged

[ios, macos] Improve snap shotter documentation. #10020

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5213133
[ios, macos] Improve snap shotter documentation.
fabian-guerra Sep 18, 2017
64e0cc2
[macos] Save snapshots in correct format
1ec5 Sep 29, 2017
d16aea7
[macos] Renamed snapshot item to Export Image
1ec5 Sep 29, 2017
dff1bc0
[ios, macos] Clarify Snapshotter documentation.
fabian-guerra Sep 29, 2017
b767c21
[ios] Fix snapshot scale
frederoni Oct 2, 2017
6ea1e41
[macOS] Fix snapshotter 4x scaling.
fabian-guerra Oct 2, 2017
6beeb87
[ios] Fix snapshotter final image scale.
fabian-guerra Oct 3, 2017
9eaed01
[ios, macos] Update snapshotter size documentation.
fabian-guerra Oct 3, 2017
21fe811
[ios, macos] Throw an exception when the snapshotter has already star…
fabian-guerra Oct 3, 2017
a072ecc
[ios, macos] Add snapshotter header example.
fabian-guerra Oct 4, 2017
73f84e7
[ios, macos] Use one of the predefined Foundation's exception names.
fabian-guerra Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 38 additions & 21 deletions platform/darwin/src/MGLMapSnapshotter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,40 +12,46 @@ MGL_EXPORT
@interface MGLMapSnapshotOptions : NSObject

/**
Creates a set of options with the minimum required information
@param styleURL the style url to use
@param camera the camera settings
@param size the image size
Creates a set of options with the minimum required information.

@param styleURL URL of the map style to snapshot. The URL may be a full HTTP or HTTPS URL,
a Mapbox URL indicating the style’s map ID (mapbox://styles/{user}/{style}), or a path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enclose mapbox://styles/{user}/{style} and nil in backticks.

to a local file relative to the application’s resource path. Specify nil for the default style.
@param size The image size.
*/
- (instancetype)initWithStyleURL:(NSURL*)styleURL camera:(MGLMapCamera*)camera size:(CGSize)size;
- (instancetype)initWithStyleURL:(nullable NSURL*)styleURL camera:(MGLMapCamera*)camera size:(CGSize)size;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Let’s take this opportunity to add spaces before *s.


#pragma mark - Configuring the map
#pragma mark - Configuring the Map

/**
The style URL for these options.
URL of the map style to snapshot. The URL may be a full HTTP or HTTPS URL,
a Mapbox URL indicating the style’s map ID (mapbox://styles/{user}/{style}), or a path
to a local file relative to the application’s resource path. Specify nil for the default style.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is read-only, so it isn’t possible for the developer to specify anything. In fact, if the developer passes nil into -initWithStyleURL:camera:size:, styleURL ends up non-nil because we choose a default style.

*/
@property (nonatomic, readonly) NSURL* styleURL;
@property (nonatomic, readonly) NSURL *styleURL;

/**
The zoom. Default is 0.
The default zoom level is 0. Overrides the altitude in the mapCamera options if set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zoom level.

The default zoom level is 0. If this property is non-zero and the camera property is non-nil, the camera’s altitude is ignored in favor of this property’s value.

*/
@property (nonatomic) double zoom;
@property (nonatomic) double zoomLevel;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sure would be nice to implement #5583 instead of offering three different ways to set the viewport on a snapshot that interact in unintuitive ways.


/**
The `MGLMapcamera` options to use.
A camera representing the viewport visible in the snapshot.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A camera representing the viewport visible in the snapshot.

If this property is non-nil and the coordinateBounds property is set to a non-empty coordinate bounds, the camera’s center coordinate and altitude are ignored in favor of the coordinateBounds property.

*/
@property (nonatomic) MGLMapCamera* camera;
@property (nonatomic) MGLMapCamera *camera;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is styleURL read-only but camera read-write? Are there situations in which it’s unsafe to change the camera? If so, we should document or fix them.


/**
A region to capture. Overrides the center coordinate
in the mapCamera options if set
The cooordinate rectangle that encompasses the bounds to capture. Overrides the center coordinate
in the mapCamera options if set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What constitutes an unset MGLCoordinateBounds? A bounds with no area, or does it have to also be centered on Null Island?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bounds with no area, if coordinateBounds are not set it will use mapCamera. Would you like to complement this sentence to make this more clear?

Overrides the center coordinate in the mapCamera options if set

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cooordinate rectangle that encompasses the bounds to capture.

If this property is non-empty and the camera property is non-nil, the camera’s center coordinate and altitude are ignored in favor of this property’s value.

*/
@property (nonatomic) MGLCoordinateBounds region;
@property (nonatomic) MGLCoordinateBounds coordinateBounds;

#pragma mark - Configuring the image
#pragma mark - Configuring the Image

/**
The size of the output image. Minimum is 64x64
The size of the output image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #10088 (comment), this property is actually intended to be measured in points (even though the minimum is in pixels).

The size of the output image, measured in points.


The image may be no less than 64 pixels wide and no less than 64 pixels tall.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let’s clarify that we really mean pixels here, because most developers will read this thinking it’s a typo:

The image may be no less than 64 pixels wide (32 points wide on a 2× display) and no less than 64 pixels tall.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately we should handle the conversion ourselves so that developers don’t have to multiply by the backing scale factor, which is inconvenient and inconsistent with MapKit: #10088.

Copy link
Contributor Author

@fabian-guerra fabian-guerra Sep 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internally we handle the scale factor so size is actually in points instead of pixels in the end. Do you think this clarifies the issue?

The size of the output image may be no less than the following dimensions:

Non-retina 64 points wide and tall.
2× 32 points wide and tall.
3× 22 points wide and tall.

*/
@property (nonatomic, readonly) CGSize size;

Expand All @@ -57,18 +63,26 @@ MGL_EXPORT

@end

#if TARGET_OS_IPHONE
/**
A block to processes the result or error of a snapshot request.

The result will be either an `MGLImage` or a `NSError`
@param snapshot The `UIImage` that was generated or `nil` if an error occurred.
@param error The error that occured or `nil` when succesful.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: successful. (×2)

*/
typedef void (^MGLMapSnapshotCompletionHandler)(UIImage* _Nullable snapshot, NSError* _Nullable error);
#else
/**
A block to processes the result or error of a snapshot request.

@param snapshot The image that was generated or `nil` if an error occurred.
@param snapshot The `NSImage` that was generated or `nil` if an error occurred.
@param error The eror that occured or `nil` when succesful.
*/
typedef void (^MGLMapSnapshotCompletionHandler)(MGLImage* _Nullable snapshot, NSError* _Nullable error);
typedef void (^MGLMapSnapshotCompletionHandler)(NSImage* _Nullable snapshot, NSError* _Nullable error);
#endif

/**
A utility object for capturing map-based images.
An immutable utility object for capturing map-based images.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As tail work, it would be helpful to add a small code example of working with MGLMapSnapshotter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tail work ticket in our ios-sdk repo https://github.com/mapbox/ios-sdk/issues/332

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to a short code example here inside the header, similar to what we do for classes like MGLShapeSource and MGLMapView, so that the example shows up at the beginning of the MGLMapSnapshotter class reference.

MGL_EXPORT
@interface MGLMapSnapshotter : NSObject
Expand All @@ -92,6 +106,9 @@ MGL_EXPORT

/**
Cancels the snapshot creation request, if any.

Once you call this method, you cannot resume the snapshot. In order to obtain the
snapshot, create a new `MGLMapSnapshotter` object.
*/
- (void)cancel;

Expand Down
28 changes: 18 additions & 10 deletions platform/darwin/src/MGLMapSnapshotter.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,26 @@
#import "MGLOfflineStorage_Private.h"
#import "MGLGeometry_Private.h"
#import "NSBundle+MGLAdditions.h"
#import "MGLStyle.h"

#if TARGET_OS_IPHONE
#import "UIImage+MGLAdditions.h"
#else
#import "NSImage+MGLAdditions.h"
#endif

const CGPoint MGLLogoImagePosition = CGPointMake(8, 8);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be interesting to make this position configurable as tail work.


@implementation MGLMapSnapshotOptions

- (instancetype _Nonnull)initWithStyleURL:(NSURL* _Nonnull)styleURL camera:(MGLMapCamera*)camera size:(CGSize) size;
- (instancetype _Nonnull)initWithStyleURL:(nullable NSURL*)styleURL camera:(MGLMapCamera*)camera size:(CGSize) size;
{
self = [super init];
if (self) {
if ( !styleURL)
{
styleURL = [MGLStyle streetsStyleURLWithVersion:MGLStyleDefaultVersion];
}
_styleURL = styleURL;
_size = size;
_camera = camera;
Expand Down Expand Up @@ -73,17 +80,17 @@ - (instancetype)initWithOptions:(MGLMapSnapshotOptions*)options;
cameraOptions.center = MGLLatLngFromLocationCoordinate2D(options.camera.centerCoordinate);
}
cameraOptions.angle = MAX(0, options.camera.heading) * mbgl::util::DEG2RAD;
cameraOptions.zoom = MAX(0, options.zoom);
cameraOptions.zoom = MAX(0, options.zoomLevel);
cameraOptions.pitch = MAX(0, options.camera.pitch);

// Region
mbgl::optional<mbgl::LatLngBounds> region;
if (!MGLCoordinateBoundsIsEmpty(options.region)) {
region = MGLLatLngBoundsFromCoordinateBounds(options.region);
mbgl::optional<mbgl::LatLngBounds> coordinateBounds;
if (!MGLCoordinateBoundsIsEmpty(options.coordinateBounds)) {
coordinateBounds = MGLLatLngBoundsFromCoordinateBounds(options.coordinateBounds);
}

// Create the snapshotter
mbglMapSnapshotter = std::make_unique<mbgl::MapSnapshotter>(*mbglFileSource, *mbglThreadPool, styleURL, size, pixelRatio, cameraOptions, region);
mbglMapSnapshotter = std::make_unique<mbgl::MapSnapshotter>(*mbglFileSource, *mbglThreadPool, styleURL, size, pixelRatio, cameraOptions, coordinateBounds);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mbglMapSnapshotter and the other ivars on MGLMapSnapshotter should begin with underscores.

}
return self;
}
Expand All @@ -96,7 +103,8 @@ - (void)startWithCompletionHandler:(MGLMapSnapshotCompletionHandler)completion;
- (void)startWithQueue:(dispatch_queue_t)queue completionHandler:(MGLMapSnapshotCompletionHandler)completion;
{
if ([self isLoading]) {
NSDictionary *userInfo = @{NSLocalizedDescriptionKey: @"Already started this snapshotter"};
NSString *errorMessage = NSLocalizedStringWithDefaultValue(@"ALREADY_STARTED_SNAPSHOTTER", nil, nil, @"Already started this snapshotter", "User-friendly error description");
NSDictionary *userInfo = @{NSLocalizedDescriptionKey: errorMessage};
NSError *error = [NSError errorWithDomain:MGLErrorDomain code:1 userInfo:userInfo];
dispatch_async(queue, ^{
completion(nil, error);
Expand All @@ -112,7 +120,7 @@ - (void)startWithQueue:(dispatch_queue_t)queue completionHandler:(MGLMapSnapshot
if (mbglError) {
NSString *description = @(mbgl::util::toString(mbglError).c_str());
NSDictionary *userInfo = @{NSLocalizedDescriptionKey: description};
NSError *error = [NSError errorWithDomain:MGLErrorDomain code:1 userInfo:userInfo];
NSError *error = [NSError errorWithDomain:MGLErrorDomain code:MGLErrorCodeSnapshotFailed userInfo:userInfo];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #10020 (comment), should we remove this error or replace it with an NSException?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense let the developer know that it has a snapshotter task running it's easy to forget this. A NSException is too drastic, I would like to continue with the NSError for the time being and evaluate this again once we made the snapshotter reusable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To elaborate, NSError is intended to problems outside the developer’s control, for issues that can’t be fixed in the developer’s own code. If the developer is reusing a snapshotter in their own code, I think that would be an error on their part and an appropriate use of NSException. But if MapKit simply sets the NSError in this case, then I guess it’s OK to follow their lead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you NSError is intended to problems outside the developer's control. NSException is a better choice. Making the changes.


// Dispatch result to origin queue
dispatch_async(queue, ^{
Expand All @@ -130,7 +138,7 @@ - (void)startWithQueue:(dispatch_queue_t)queue completionHandler:(MGLMapSnapshot
UIGraphicsBeginImageContext(mglImage.size);

[mglImage drawInRect:CGRectMake(0, 0, mglImage.size.width, mglImage.size.height)];
[logoImage drawInRect:CGRectMake(8, mglImage.size.height - (8 + logoImage.size.height), logoImage.size.width,logoImage.size.height)];
[logoImage drawInRect:CGRectMake(MGLLogoImagePosition.x, mglImage.size.height - (MGLLogoImagePosition.y + logoImage.size.height), logoImage.size.width,logoImage.size.height)];
UIImage *compositedImage = UIGraphicsGetImageFromCurrentImageContext();

UIGraphicsEndImageContext();
Expand All @@ -139,7 +147,7 @@ - (void)startWithQueue:(dispatch_queue_t)queue completionHandler:(MGLMapSnapshot
NSImage *compositedImage = mglImage;

[compositedImage lockFocus];
[logoImage drawInRect:CGRectMake(8, 8, logoImage.size.width,logoImage.size.height)];
[logoImage drawInRect:CGRectMake(MGLLogoImagePosition.x, MGLLogoImagePosition.y, logoImage.size.width,logoImage.size.height)];
[compositedImage unlockFocus];
#endif

Expand Down
2 changes: 2 additions & 0 deletions platform/darwin/src/MGLTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ typedef NS_ENUM(NSInteger, MGLErrorCode) {
MGLErrorCodeParseStyleFailed = 4,
/** An attempt to load the style failed. */
MGLErrorCodeLoadStyleFailed = 5,
/** An error occurred while snapshotting the map. */
MGLErrorCodeSnapshotFailed = 6,
};

/** Options for enabling debugging features in an `MGLMapView` instance. */
Expand Down
28 changes: 14 additions & 14 deletions platform/ios/app/MBXSnapshotsViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,36 +18,36 @@ @interface MBXSnapshotsViewController ()

@implementation MBXSnapshotsViewController {
// Top row
MGLMapSnapshotter* snapshotterTL;
MGLMapSnapshotter* snapshotterTM;
MGLMapSnapshotter* snapshotterTR;
MGLMapSnapshotter* topLeftSnapshotter;
MGLMapSnapshotter* topCenterSnapshotter;
MGLMapSnapshotter* topRightSnapshotter;

// Bottom row
MGLMapSnapshotter* snapshotterBL;
MGLMapSnapshotter* snapshotterBM;
MGLMapSnapshotter* snapshotterBR;
MGLMapSnapshotter* bottomLeftSnapshotter;
MGLMapSnapshotter* bottomCenterSnapshotter;
MGLMapSnapshotter* bottomRightSnapshotter;
}

- (void)viewDidLoad {
[super viewDidLoad];

// Start snapshotters
snapshotterTL = [self startSnapshotterForImageView:_snapshotImageViewTL coordinates:CLLocationCoordinate2DMake(37.7184, -122.4365)];
snapshotterTM = [self startSnapshotterForImageView:_snapshotImageViewTM coordinates:CLLocationCoordinate2DMake(38.8936, -77.0146)];
snapshotterTR = [self startSnapshotterForImageView:_snapshotImageViewTR coordinates:CLLocationCoordinate2DMake(-13.1356, -74.2442)];
topLeftSnapshotter = [self startSnapshotterForImageView:_snapshotImageViewTL coordinates:CLLocationCoordinate2DMake(37.7184, -122.4365)];
topCenterSnapshotter = [self startSnapshotterForImageView:_snapshotImageViewTM coordinates:CLLocationCoordinate2DMake(38.8936, -77.0146)];
topRightSnapshotter = [self startSnapshotterForImageView:_snapshotImageViewTR coordinates:CLLocationCoordinate2DMake(-13.1356, -74.2442)];

snapshotterBL = [self startSnapshotterForImageView:_snapshotImageViewBL coordinates:CLLocationCoordinate2DMake(52.5072, 13.4247)];
snapshotterBM = [self startSnapshotterForImageView:_snapshotImageViewBM coordinates:CLLocationCoordinate2DMake(60.2118, 24.6754)];
snapshotterBR = [self startSnapshotterForImageView:_snapshotImageViewBR coordinates:CLLocationCoordinate2DMake(31.2780, 121.4286)];
bottomLeftSnapshotter = [self startSnapshotterForImageView:_snapshotImageViewBL coordinates:CLLocationCoordinate2DMake(52.5072, 13.4247)];
bottomCenterSnapshotter = [self startSnapshotterForImageView:_snapshotImageViewBM coordinates:CLLocationCoordinate2DMake(60.2118, 24.6754)];
bottomRightSnapshotter = [self startSnapshotterForImageView:_snapshotImageViewBR coordinates:CLLocationCoordinate2DMake(31.2780, 121.4286)];
}

- (MGLMapSnapshotter*) startSnapshotterForImageView:(UIImageView*) imageView coordinates:(CLLocationCoordinate2D) coordinates {
// Create snapshot options
MGLMapCamera* mapCamera = [[MGLMapCamera alloc] init];
mapCamera.pitch = 20;
mapCamera.centerCoordinate = coordinates;
MGLMapSnapshotOptions* options = [[MGLMapSnapshotOptions alloc] initWithStyleURL:[NSURL URLWithString:@"mapbox://styles/mapbox/traffic-day-v2"] camera:mapCamera size:CGSizeMake(imageView.frame.size.width, imageView.frame.size.height)];
options.zoom = 10;
MGLMapSnapshotOptions* options = [[MGLMapSnapshotOptions alloc] initWithStyleURL:[MGLStyle satelliteStreetsStyleURL] camera:mapCamera size:CGSizeMake(imageView.frame.size.width, imageView.frame.size.height)];
options.zoomLevel = 10;

// Create and start the snapshotter
MGLMapSnapshotter* snapshotter = [[MGLMapSnapshotter alloc] initWithOptions:options];
Expand Down
29 changes: 19 additions & 10 deletions platform/macos/app/MapDocument.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ - (IBAction)takeSnapshot:(id)sender {
MGLMapCamera *camera = self.mapView.camera;

MGLMapSnapshotOptions* options = [[MGLMapSnapshotOptions alloc] initWithStyleURL:self.mapView.styleURL camera:camera size:self.mapView.bounds.size];
options.zoom = self.mapView.zoomLevel;
options.zoomLevel = self.mapView.zoomLevel;

// Create and start the snapshotter
snapshotter = [[MGLMapSnapshotter alloc] initWithOptions:options];
Expand All @@ -177,6 +177,7 @@ - (IBAction)takeSnapshot:(id)sender {

// Set the default name for the file and show the panel.
NSSavePanel* panel = [NSSavePanel savePanel];

[panel setNameFieldStringValue:newName];
[panel beginSheetModalForWindow:window completionHandler:^(NSInteger result){
if (result == NSFileHandlingPanelOKButton) {
Expand All @@ -196,16 +197,24 @@ - (IBAction)takeSnapshot:(id)sender {

}

NSString *extension = [[fileURL pathExtension] lowercaseString];
NSBitmapImageFileType fileType;
if ([extension isEqualToString:@"png"]) {
NSString *uti;
[fileURL getResourceValue:&uti forKey:NSURLTypeIdentifierKey error:nil];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this doesn’t work because no file has been laid down by this point. This code ends up producing a TIFF no matter what extension is specified.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #10090.

NSBitmapImageFileType fileType = NSTIFFFileType;

if (UTTypeConformsTo((__bridge CFStringRef)uti, kUTTypePNG)) {
fileType = NSPNGFileType;
} else if ([extension isEqualToString:@"gif"]) {
fileType = NSGIFFileType;
} else if ([extension isEqualToString:@"jpg"] || [extension isEqualToString:@"jpeg"]) {
fileType = NSJPEGFileType;
} else {
fileType = NSTIFFFileType;
}
if (UTTypeConformsTo((__bridge CFStringRef)uti, kUTTypeGIF)) {
fileType = NSGIFFileType;
}
if (UTTypeConformsTo((__bridge CFStringRef)uti, kUTTypeJPEG)) {
fileType = NSJPEGFileType;
}
if (UTTypeConformsTo((__bridge CFStringRef)uti, kUTTypeJPEG2000)) {
fileType = NSJPEGFileType;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kUTTypeJPEG2000 translates to NSJPEG2000FileType, not NSJPEGFileType.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #10090.

}
if (UTTypeConformsTo((__bridge CFStringRef)uti, kUTTypeBMP)) {
fileType = NSBitmapImageFileTypeBMP;
}

NSData *imageData = [bitmapRep representationUsingType:fileType properties:@{}];
Expand Down