This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Define user dot constants in implementation file #10087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
annotations
friedbunny
approved these changes
Sep 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9886 moved these constant declarations to a header file, but they should’ve been
externed and defined in the original implementation file. Otherwise, the linker could end up seeing duplicate symbols. I’m not sure why this hasn’t been failing the iOS builds, but it ended up failing tvOS builds in #9319 when I tried to include this header in the tvOS SDK./cc @friedbunny