This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Hold off handling hover events untill map has been created #10142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -415,6 +415,10 @@ public boolean onGenericMotionEvent(MotionEvent event) { | |||
|
|
|||
| @Override | |||
| public boolean onHoverEvent(MotionEvent event) { | |||
| if (mapZoomButtonController == null) { | |||
There was a problem hiding this comment.
What about extracting this block of code into a private method? IMO, we should try to keep public methods as clean as possible so it reads like pseudocode (a.k.a. no conditionals, fors, etc.).
tobrun
force-pushed
the
tvn-chromebook-fix
branch
from
72dc434
to
7722cdf
Compare
|
@Guardiola31337 I revised the code with your remarks also persisted this change to other parts in the MapView.java. Can you re-review? |
20 tasks
20 tasks
This was referenced Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that on a Chromebook, there are situations the mouse is hovering while the map isn't created yet.