This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Cherry pick #10107: Map::cameraForGeometry() #10166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
approved these changes
Oct 9, 2017
fabian-guerra
suggested changes
Oct 9, 2017
platform/ios/src/MGLMapView.h
Outdated
| (close to the ground) as possible while still including the entire shape. The | ||
| camera object uses the current pitch. | ||
| */ | ||
| - (MGLMapCamera *)cameraThatFitsShape:(MGLShape *)shape direction:(double)direction edgePadding:(UIEdgeInsets)insets; |
There was a problem hiding this comment.
If the direction is measured in degrees please use CLLocationDirection instead of double.
platform/macos/src/MGLMapView.h
Outdated
| (close to the ground) as possible while still including the entire shape. The | ||
| camera object uses the current pitch. | ||
| */ | ||
| - (MGLMapCamera *)cameraThatFitsShape:(MGLShape *)shape direction:(double)direction edgePadding:(NSEdgeInsets)insets; |
There was a problem hiding this comment.
Same comment as on iOS. If the direction is measured in degrees please use CLLocationDirection instead of double.
…. On macOS, also added -[MGLMapView setCamera: withDuration: animationTimingFunction: edgePadding: completionHandler:] for parity with iOS
asheemmamoowala
force-pushed
the
cherry-pick-9809
branch
from
349c7a6
to
8c33712
Compare
20 tasks
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick changes from #10107 for #9809