Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix broken android unit tests, update test make target to SDK #10387

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Nov 6, 2017

The java unit tests were broken, CI didn't notice as we were trying to build the unit tests from the testapp while they are now found in the SDK. This PR updates the make target and fixes the broken tests.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Nov 6, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Nov 6, 2017
@tobrun tobrun self-assigned this Nov 6, 2017
@@ -74,15 +74,6 @@ public void center() {
}

@Test
public void emptySpan() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not valid anymore with #9955

@zugaldia
Copy link
Member

zugaldia commented Nov 6, 2017

This PR updates the make target and fixes the broken tests.

Good catch. Is this still a WIP? I don't see any changes to the Makefile in the PR.

@tobrun
Copy link
Member Author

tobrun commented Nov 6, 2017

yes forgot to push, in 839e0a0

@tobrun tobrun merged commit 24de48b into release-agua Nov 6, 2017
@tobrun tobrun deleted the tvn-fix-unit-tests branch November 6, 2017 17:53
This was referenced Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants