This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
LatLng.wrap should return a new instance of LatLng #10769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LatLng.wrap shoudl wrap mulpiples of max value to max
osana
force-pushed
the
osana-latlng-wrap
branch
from
2274617 to
0aa00cf
Compare
asheemmamoowala
approved these changes
Dec 21, 2017
| assertEquals("longitude wrapped max value", newLatlng.getLongitude(), 180.0, DELTA); | ||
|
|
||
| newLatlng = new LatLng(45.0, -180.0).wrap(); | ||
| assertEquals("longitude wrapped min value", newLatlng.getLongitude(), -180.0, DELTA); |
There was a problem hiding this comment.
For completeness, can we add a test for longitude >180
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LatLng.wrap should wrap multiples of max value to max
closes #10767