Gestures #1115
Gestures #1115
Conversation
… processing on background threads.
|
Waiting for Travis to 👍 and then will merge. |
| @@ -1032,10 +1032,11 @@ - (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecogni | |||
|
|
|||
| - (void)trackGestureEvent:(NSString *)gesture forRecognizer:(UIGestureRecognizer *)recognizer | |||
| { | |||
| CGPoint ptInView = CGPointMake([recognizer locationInView:recognizer.view].x, [recognizer locationInView:recognizer.view].y); | |||
| const CLLocationCoordinate2D coord = [self convertPoint:ptInView toCoordinateFromView:recognizer.view]; | |||
There was a problem hiding this comment.
This is still going to have a performance impact, doing projection math at the Cocoa level every hit of a gesture. We may want to see if we can do this in a const method in a non-main thread.
There was a problem hiding this comment.
I'm not sure that it can be put into a non-main UI thread, as the convertPoint method relies on [UIView convertPoint:fromView] itself.
There was a problem hiding this comment.
We may want to see if we can do this in a
constmethod in a non-main thread.
Yeah, I meant more changing the C++ to make this safer somehow for non-main threads — like snapshotting the TransformState or something. Looking into it.
|
Actually will address issues in #1116 |
|
Travis approved the commits, but will do some more research into #1116 before merging. |
|
Obsoleted by #1132. |
To address some
#1103#1116 issues.