Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] More Custom layer integration tests #11323

Merged
merged 1 commit into from
Feb 27, 2018
Merged

[ios] More Custom layer integration tests #11323

merged 1 commit into from
Feb 27, 2018

Conversation

asheemmamoowala
Copy link
Contributor

@asheemmamoowala asheemmamoowala commented Feb 26, 2018 •
edited
Loading

Added a few more integration tests for custom layer.
The testOpenGLLayerDoesNotLeakWhenRemovedFromStyle test fails, highlighting the issue mentioned in #11291(comment)

cc @akitchen @julianrex

akitchen
akitchen approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@akitchen akitchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the use of @autoreleasepool here. This is an improvement on the weak pointer test I was playing around with.

@akitchen
Copy link
Contributor

Fantastic test failure! Let's merge this in and keep iterating...

@akitchen akitchen merged commit fafedb6 into gl-layer-memory-fix Feb 27, 2018
@friedbunny friedbunny deleted the custom-layer-style-changed-leak branch March 7, 2018 18:33
@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS tests labels Mar 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akitchen akitchen akitchen approved these changes

@julianrex julianrex Awaiting requested review from julianrex

Assignees
No one assigned
Labels
iOS Mapbox Maps SDK for iOS tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asheemmamoowala @akitchen @friedbunny