This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[agua] Clamp TileJSON bounds #11425
Merged
[agua] Clamp TileJSON bounds #11425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2018 11:38
…d requesting parent tiles of ideal zoom tiles.
asheemmamoowala
changed the title
There was a problem hiding this comment.
👍 confirmed this fixes the issue I was seeing in #11411, but we should probably get someone else more familiar with the core mbgl code to officially approve 😄
friedbunny
approved these changes
Mar 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11411.
Also cherry-picked #11227, to address #11213 and #11209 for agua.
In mapbox-gl-js, TileJSON bounds longitudes are clamped to [-180,180]. Existing styles benefitted from this clamping when their bounds were outside this range.
(For example
[-179.9999893871037, -89.99993255000595, 180.00000000000006, 90])In mapbox-gl-native, these longitude values are wrapped to:
[179.9999893871037, -179.99999999999994]), resulting in bounds with a skinny horizontal extent.Changed the TileJSON conversion to clamp the bounds, to provide results consistent with mapbox-gl-js.