This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Array expression literal #11457
Merged
Array expression literal #11457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
commented
Mar 15, 2018
| Object[] stopZero = new Object[] {0, 1}; | ||
| Object[] stopOne = new Object[] {1, 2}; | ||
| Object[] stopTwo = new Object[] {2, 3}; | ||
| Object[] expected = new Object[] {"interpolate", new Object[] {"linear"}, 12, stopZero, stopOne, stopTwo}; |
There was a problem hiding this comment.
above construction for stops wasn't correct, stops are not allowed to be nested arrays
tobrun
commented
Mar 15, 2018
| Object[] actual = at(literal(3), literal(new Object[] {"one", "two"})).toArray(); | ||
| assertTrue("expression should match", Arrays.deepEquals(expected, actual)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testAtLiteral() throws Exception { | ||
| Object[] expected = new Object[] {"at", 3, new Object[] {"one", "two"}}; | ||
| Object[] expected = new Object[] {"at", 3, new Object[] {"literal", new Object[] {"one", "two"}}}; |
There was a problem hiding this comment.
had to update this line as this syntax would be required to pass in an Object[] to core
tobrun
force-pushed
the
tvn-array-expression-literal
branch
from
b267e55
to
50b1742
Compare
LukasPaczos
approved these changes
Mar 16, 2018
This was referenced Mar 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11421, this PR adds correct integration for
literal(Object[]):Not commited but a small end-to-end test with:
Results in showing 2 as symbol text in: