Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Tests and fix for infinite loop when setting shape to nil in MGLMapViewDelegate methods #11614

Merged
merged 17 commits into from
May 21, 2018
Merged

Tests and fix for infinite loop when setting shape to nil in MGLMapViewDelegate methods #11614

merged 17 commits into from
May 21, 2018

Commits on May 21, 2018

  1. Failing test for #11180

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    5bdf9bd View commit details
    Browse the repository at this point in the history

  2. Change order of finish function, to stop infinite loop

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    3b61b51 View commit details
    Browse the repository at this point in the history

  3. Add test for setting shape source to nil from mapViewRegionIsChanging

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    33a5b48 View commit details
    Browse the repository at this point in the history

  4. Added comments to clarify changes.

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    4418c14 View commit details
    Browse the repository at this point in the history

  5. Do not reset transition function if the transition has completed.

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    ace5bb1 View commit details
    Browse the repository at this point in the history

  6. Add failing test for camera transition (reset north). Renaming of tes… 

    …t classes.
    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    a73d2ad View commit details
    Browse the repository at this point in the history

  7. Rejig handling of transition finish lambda. Potentially addresses #5833

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    dd96749 View commit details
    Browse the repository at this point in the history

  8. Move across KIF cancel transition test. Added flyTo test.

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    7dae8fa View commit details
    Browse the repository at this point in the history

  9. Removed test assert.

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    aa6c1e5 View commit details
    Browse the repository at this point in the history

  10. Adjusted wait periods (based on documented durations) to reduce test … 

    …times.
    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    11b8eb8 View commit details
    Browse the repository at this point in the history

  11. Use built-in expectation functionality to replace performSelector dance.

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    9accdee View commit details
    Browse the repository at this point in the history

  12. Added additional test for interrupting a transition, and associated fix. 

    Added failing (currently disabled) test, where the interruption still triggers an infinite loop.
    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    1af29e2 View commit details
    Browse the repository at this point in the history

  13. Added additional tests (these currently fail - so are disabled)

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    8ab06dd View commit details
    Browse the repository at this point in the history

  14. Removed unused var.

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    b06d531 View commit details
    Browse the repository at this point in the history

  15. Nit change.

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    13cf449 View commit details
    Browse the repository at this point in the history

  16. Added additional comments. Disabled pending tests in code, rather tha… 

    …n via scheme.
    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    c0cf9ae View commit details
    Browse the repository at this point in the history

  17. Updated changelogs to use PR id.

    Julian Rex committed May 21, 2018
    Configuration menu
    Copy the full SHA
    95b8967 View commit details
    Browse the repository at this point in the history