This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
fixes #1181: fix lat/lng & zoom ordering problems #1194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two things going on here:
3
like MapKit so that we don't ever see world edges or a wrapping, repeating map. However, in various center set routines, we weren't checking that the level was at least3
before trying to move the map, which could have limited it artificially and failed at setting the center desired. This abstracts out anMGLMinimumZoom
constant since we use it in various places anyway, plus ensures that we are at the minimum zoom on iOS before changing viewport properties.Map
'stransform
except forgetLatLng()
, which queriedstate
instead. This could cause things to be out of sync when setting properties one after the other in the same run loop pass./cc @kkaefer just to be sure.