This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove unused generated OpenGL programs #12287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
force-pushed
the
release-node-v4.0.0-remove-unused-programs
branch
from
167de70 to
da75c4a
Compare
jfirebaugh
approved these changes
Jul 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #9185 we started generating DDS-specific program objects to work around some OpenGL implementations that were slow with constant vertex attributes. When reusing a map object with many different styles, this leads to the generation of many permutations of Program objects that are retained indefinitely. This patch adds a retention duration which is 100 frames in continuous mode, and 20 frames for static frames.