This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Allow unwrapped arguments in match expressions #12332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
iOS
1ec5
force-pushed
the
1ec5-match-literal-11830
branch
from
62d0862
to
d3241f9
Compare
1ec5
force-pushed
the
1ec5-match-literal-11830
branch
from
d3241f9
to
0b69716
Compare
1ec5
force-pushed
the
1ec5-match-literal-11830
branch
from
0b69716
to
13627e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11866 assumes the arguments to an
MGL_MATCHexpression are all expressions. But for use cases like #11830 (comment), it feels natural to insert a raw object instead of a constant-value expression containing that object. This change allows either an expression or a non-expression as an argument to a match expression. There probably are other places where we’re assuming that arguments are wrapped in expressions, but this is the most likely one to trip up a developer./cc @fabian-guerra