This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] coveredByChildren is false if at least one child is uncovered #12371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another spin-off from #12310 - I discovered that the
coveredByChildren
algorithm returnstrue
if at least one child is entirely covered by its grandchildren.Because we are limiting the number of tiles in #12310, some edge cases were causing the lower zoom tiles to disappear - notice that symbols still appear because their rendering is unaffected by clip IDs.
On the screenshots below, notice how the uppermost tile is not rendered (only its symbols), and its absence of depth buffer color:
With the changes applied, the uppermost tile reappears, along with its depth buffer (dark grey):
/cc @kkaefer @asheemmamoowala