Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Validate if gesture detector is able to handle gesture #12375

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Validate if gesture detector is able to handle gesture #12375

merged 1 commit into from
Jul 12, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jul 12, 2018

Capturing from an end-user:

mapGestureDetector is set during onSurfaceCreated() whereas onTouchEvent only checks if nativeMapView != null which is false after onGlobalLayout(). onGlobalLayout() occurs before onSurfaceCreated() and its possible that a touch event can happen in the middle. Therefore, onTouchEvent should also check that mapGestureDetector != null which onGenericMotionEvent does already.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jul 12, 2018
@tobrun tobrun added this to the android-v6.4.0 milestone Jul 12, 2018
@tobrun tobrun self-assigned this Jul 12, 2018
@tobrun tobrun requested a review from LukasPaczos July 12, 2018 07:31
@tobrun tobrun merged commit b79b971 into master Jul 12, 2018
@tobrun tobrun deleted the tvn-harden-touchevent branch July 12, 2018 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v6.4.0-espresso
Development

Successfully merging this pull request may close these issues.
2 participants
@tobrun @LukasPaczos