This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
line-progress expression + line-gradient example #12615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-gradient-line-integration
branch
from
a00a5a0 to
c0f2109
Compare
|
@tobrun thanks for pointing this out! I'll investigate what's happening there |
|
Capturing from @pozdnyakov that we are missing integration for lineMetrics (see render test example here. We will need to expose this as a GeoJsonOptions configuration. |
tobrun
force-pushed
the
tvn-gradient-line-integration
branch
from
c0f2109 to
e46eeeb
Compare
pozdnyakov
force-pushed
the
line_gradient
branch
2 times, most recently
from
d7fefa8 to
7f5d5c8
Compare
|
The latest patch at #12575 fixes the issue. Thanks. |
|
|
tobrun
force-pushed
the
tvn-gradient-line-integration
branch
2 times, most recently
from
bded6c6 to
e88c1c7
Compare
tobrun
force-pushed
the
tvn-gradient-line-integration
branch
from
e88c1c7 to
88a6f85
Compare
|
@pozdnyakov this PR targets merging into your branch so we can merge everything together. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #12575
This PR adds an example integration of
line-gradientproperty added in #12575 and adds expression for theline-progressexpression from the style spec here.Currently the example isn't rendering as expected, to be fixed before merging:
Todo:
@pozdnyakov are you seeing this correctly being rendered on other platforms?