Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

prevent crash when expression evaluates to default, no pattern #12896

Merged
merged 1 commit into from
Sep 19, 2018
Merged

prevent crash when expression evaluates to default, no pattern #12896

merged 1 commit into from
Sep 19, 2018

Conversation

mollymerp
Copy link
Contributor

fix #12835

@mollymerp mollymerp added Core The cross-platform C++ core, aka mbgl bug labels Sep 14, 2018
@mollymerp mollymerp mentioned this pull request Sep 14, 2018
Merged
kkaefer
kkaefer approved these changes Sep 18, 2018
View reviewed changes
src/mbgl/renderer/paint_property_binder.hpp Outdated
if (!patternDependencies) return;
if (!patternPositions.empty()) {

if (patternDependencies->mid == "") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be .empty()

@mollymerp mollymerp merged commit 80bdbeb into master Sep 19, 2018
@mollymerp mollymerp deleted the pattern-expression-fix branch September 19, 2018 00:31
@friedbunny friedbunny added the needs changelog Indicates PR needs a changelog entry prior to merging. label Sep 19, 2018
@friedbunny friedbunny mentioned this pull request Sep 19, 2018
Merged
@friedbunny friedbunny removed needs changelog Indicates PR needs a changelog entry prior to merging. labels Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kkaefer kkaefer kkaefer approved these changes

Assignees
No one assigned
Labels
bug Core The cross-platform C++ core, aka mbgl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

line-pattern or fill-pattern with invalid values crashes
3 participants
@mollymerp @kkaefer @friedbunny