This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
emplace into threadSet #1291
Merged
emplace into threadSet #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
threadset-emplace
branch
from
98c8159
to
aed12c9
Compare
|
I rebased this on master and it seems to be triggering an assertion failure: |
|
For context, this change is related to https://github.com/mapbox/node-mapbox-gl-native/issues/114, it's quite possible that additional work is needed to resolve the underlying issues. |
Map thread and Main thread should be separated in Mode::Static now
The MapContext can only run on its own thread because it is registering a EnvironmentScope and it is making many assertions on Debug mode if its methods are being called on the Map thread.
tmpsantos
force-pushed
the
threadset-emplace
branch
from
aed12c9
to
b162fb7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map thread and Main thread should be separated in Mode::Static now
/cc @tmpsantos