Don't wrap LatLngBounds #13540
Don't wrap LatLngBounds #13540
Conversation
tobrun
force-pushed
the
tvn-dont-wrap-bounds
branch
3 times, most recently
from
d034330
to
bae2dfe
Compare
|
|
||
| if (latNorth < latSouth) { | ||
| throw new IllegalArgumentException("latNorth cannot be less than latSouth"); | ||
| } |
There was a problem hiding this comment.
Why do we need to remove this check?
I think we should add a similar check for lonEast being always >= lonWest
There was a problem hiding this comment.
Also LatLngBounds union, intersect, getCenter, getLongitudeSpan, fromLatLngs can be simplified a lot as lonEast >= lonWest
There was a problem hiding this comment.
GeometryConstants for longitude need to be changed. Do we allow longitude to infinity ?
There was a problem hiding this comment.
Another place that should be adjusted (I would think) is the Projection.getVisibleRegion() as it can go over dateline and be rotated (on top of that)
There was a problem hiding this comment.
@LukasPaczos I absolutely agree that #13419 and this one compliment one another. I can move over @tobrun's example or have both PRs merged - either way is fine by me
There was a problem hiding this comment.
Why do we need to remove this check?
my bad, this was re-added.
I think we should add a similar check for lonEast being always >= lonWest
sure, added in follow up commit
Also LatLngBounds union, intersect, getCenter, getLongitudeSpan, fromLatLngs can be simplified a lot as lonEast >= lonWest
Simplified, so not a requirement for this PR?
GeometryConstants for longitude need to be changed. Do we allow longitude to infinity ?
I went with Double.MAX_VALUE in a follow up commit, not seeing that infinity will unlock any use-cases.
tobrun
force-pushed
the
tvn-dont-wrap-bounds
branch
from
bae2dfe
to
9248751
Compare
tobrun
force-pushed
the
tvn-dont-wrap-bounds
branch
from
9248751
to
f48f86b
Compare
* [android] - don't wrap LatLngBounds * Update GeometryConstants.java * Update NativeMapTest
Closes #13186