Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Android libraries vendorization #13712

Merged
merged 4 commits into from
Jan 15, 2019
Merged

Android libraries vendorization #13712

merged 4 commits into from
Jan 15, 2019

Conversation

@LukasPaczos LukasPaczos added Android Mapbox Maps SDK for Android ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold in progress labels Jan 10, 2019
@LukasPaczos LukasPaczos added this to the android-v7.1.0 milestone Jan 10, 2019
@tobrun
Copy link
Member

tobrun commented Jan 11, 2019

* What went wrong:
Could not determine the dependencies of task ':MapboxGLAndroidSDKTestApp:compileDebugJavaWithJavac'.
> Could not resolve all task dependencies for configuration ':MapboxGLAndroidSDKTestApp:debugCompileClasspath'.
   > Could not resolve project :MapboxAndroidGestures.
     Required by:
         project :MapboxGLAndroidSDKTestApp > project :MapboxGLAndroidSDK
      > Unable to find a matching configuration of project :MapboxAndroidGestures: None of the consumable configurations have attributes.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 4s
Makefile:630: recipe for target 'android-arm-v7' failed
make: *** [android-arm-v7] Error 1

Steps to reproduce:

  • mkdir temp && cd temp/
  • git clone git@github.com:mapbox/mapbox-gl-native.git && cd mapbox-gl-native/
  • git checkout lp-vendorize-android-libs
  • make android

@LukasPaczos LukasPaczos force-pushed the lp-vendorize-android-libs branch 5 times, most recently from 78ef0a1 to ac26f62 Compare January 11, 2019 17:46
@LukasPaczos LukasPaczos force-pushed the lp-vendorize-android-libs branch 2 times, most recently from cb32130 to ff8fcdd Compare January 14, 2019 11:54
@tobrun
Copy link
Member

tobrun commented Jan 14, 2019

Doing the same setup as #13712 (comment) results initially in:

* What went wrong:
Could not determine the dependencies of task ':MapboxGLAndroidSDKTestApp:compileDebugJavaWithJavac'.
> Could not resolve all task dependencies for configuration ':MapboxGLAndroidSDKTestApp:debugCompileClasspath'.
   > Could not resolve project :services-turf.
     Required by:
         project :MapboxGLAndroidSDKTestApp
      > Unable to find a matching configuration of project :services-turf: None of the consumable configurations have attributes.
   > Could not resolve project :libcore.
     Required by:
         project :MapboxGLAndroidSDKTestApp > project :MapboxGLAndroidSDK
      > Unable to find a matching configuration of project :libcore: None of the consumable configurations have attributes.
   > Could not resolve project :libtelemetry.
     Required by:
         project :MapboxGLAndroidSDKTestApp > project :MapboxGLAndroidSDK
      > Unable to find a matching configuration of project :libtelemetry: None of the consumable configurations have attributes.
   > Could not resolve project :MapboxAndroidGestures.
     Required by:
         project :MapboxGLAndroidSDKTestApp > project :MapboxGLAndroidSDK
      > Unable to find a matching configuration of project :MapboxAndroidGestures: None of the consumable configurations have attributes.
   > Could not resolve project :services-geojson.
     Required by:
         project :MapboxGLAndroidSDKTestApp > project :MapboxGLAndroidSDK
      > Unable to find a matching configuration of project :services-geojson: None of the consumable configurations have attributes.

Rerunning it after getting above, it does however build as expected:

BUILD SUCCESSFUL in 7m 52s

@LukasPaczos LukasPaczos force-pushed the lp-vendorize-android-libs branch 7 times, most recently from 2210581 to 1de7722 Compare January 14, 2019 17:20
@LukasPaczos LukasPaczos removed in progress ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Jan 14, 2019
@LukasPaczos LukasPaczos requested a review from tobrun January 14, 2019 17:37
@LukasPaczos LukasPaczos added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Jan 14, 2019
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LukasPaczos LukasPaczos force-pushed the lp-vendorize-android-libs branch from 1de7722 to c502dc6 Compare January 15, 2019 10:24
@LukasPaczos LukasPaczos removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Jan 15, 2019
@LukasPaczos LukasPaczos force-pushed the lp-vendorize-android-libs branch from c502dc6 to ab266b8 Compare January 15, 2019 12:05
@LukasPaczos LukasPaczos force-pushed the lp-vendorize-android-libs branch from 83bdf29 to de12f59 Compare January 15, 2019 12:15
@LukasPaczos LukasPaczos merged commit 52bc118 into master Jan 15, 2019
@LukasPaczos LukasPaczos deleted the lp-vendorize-android-libs branch January 15, 2019 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants