This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Don't call OnSurfaceCreated from the main thread #14244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
reviewed
Mar 27, 2019
| @@ -10,6 +10,7 @@ android { | |||
| versionCode 13 | |||
| versionName "6.0.0" | |||
| testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner" | |||
| //testInstrumentationRunnerArgument 'size', 'large' | |||
There was a problem hiding this comment.
actually not, I took my a while to figure out this arg 🙃 so I was like, let's keep it there for future reference.
There was a problem hiding this comment.
I'm going to remove, we need command line support for this not a gradle configuration
tobrun
force-pushed
the
tvn-surface-created-main
branch
from
941f633
to
ff99511
Compare
LukasPaczos
approved these changes
Mar 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #14127, closes #14224. We shouldn't call
MapRenderer#OnSurfaceCreatedfrom theSurfaceHolderCallback. This callback is invoked on the main thread and is invoked in pair with the already existing one on the render thread (this was a misassumption made in #14127 that this wasn't invoked in pairs).This solves the root crash of
Which resulted in a bunch of undefined behavior crashes as #14224.
Have been running tests for hours and everything seems stable.