This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Less strict rules for adding render layers to sources #14527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
requested review from
kkaefer and
alexshalamov
and removed request for
kkaefer
pozdnyakov
force-pushed
the
mikhail_fix_14523
branch
from
82c2a9b
to
51b3a9c
Compare
alexshalamov
approved these changes
Apr 29, 2019
src/mbgl/renderer/render_layer.cpp
Outdated
| && baseImpl->visibility != style::VisibilityType::None; | ||
| } | ||
|
|
||
| bool RenderLayer::zoomFits(float zoom) const { |
There was a problem hiding this comment.
canRenderAtZoom, withinSupportedZoomRange or supportsZoom?
There was a problem hiding this comment.
supportsZoom lgtm!
pozdnyakov
force-pushed
the
mikhail_fix_14523
branch
from
51b3a9c
to
189ec48
Compare
This was referenced Apr 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the partial revert of 8faf47a
Zoom check at
RenderLayer::needsRendering()was too strict, which prevented adding tile buckets for the layers whoseminZoomwas just slightly bigger thanzoomHistory.lastZoom(e.g. lastZoom: 11.9522, min zoom: 12).Fixes: #14523