This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Option to provide custom values for location camera transition #14606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
reviewed
May 9, 2019
| } | ||
|
|
||
| void setCameraMode(@CameraMode.Mode final int cameraMode, @Nullable Location lastLocation, | ||
| @Nullable OnLocationCameraTransitionListener internalTransitionListener) { | ||
| @Nullable OnLocationCameraTransitionListener internalTransitionListener, |
There was a problem hiding this comment.
listeners should ideally be set as last parameter to improve consumption from kotlin code
There was a problem hiding this comment.
context in this user report: #12010
There was a problem hiding this comment.
Ah, I've already pushed the changes but since OnLocationCameraTransitionListener is not a SAM interface it doesn't actually matter.
There was a problem hiding this comment.
lol, in any case it's a bit more readable 🙃
|
/cc @mapbox/navigation-android |
LukasPaczos
force-pushed
the
lp-custom-tracking-transition-14539
branch
2 times, most recently
from
81954a2
to
48b07bf
Compare
LukasPaczos
force-pushed
the
lp-custom-tracking-transition-14539
branch
from
48b07bf
to
eb78633
Compare
tobrun
approved these changes
May 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14539.
This PR adds an option to provide custom transition duration, zoom, bearing and tilt values for the location tracking transition animation.
