[ios] Test map view within tab bar controller #14704

jmkiley · 2019-05-17T22:48:10Z

Adds tests for #14232 Part of ongoing work related to #14654,

I'm currently exploring how to detect that the map itself has become unresponsive. Currently planning to move the map after the timer has run for a few seconds, then check whether the map's center has changed.

cc @julianrex

jmkiley · 2019-05-17T22:49:37Z

platform/ios/Integration Test Harness/Assets.xcassets/AppIcon.appiconset/Contents.json

@@ -84,6 +84,11 @@
      "idiom" : "ipad",
      "size" : "83.5x83.5",
      "scale" : "2x"
+    },


to do: remove this.

friedbunny · 2019-05-21T00:21:33Z

platform/ios/Integration Tests/MGLTabBarControllerTests.m

+        }];
+    });
+
+    [self waitForExpectationsWithTimeout:10 handler:^(NSError * _Nullable error) {


FYI: timing based tests taking much, much longer than expected are why the Integration Tests target isn’t run on CI. Even though we’re not expecting to make these tests run on virtualized CI again, reducing their dependency on timing is always something to strive towards.

Thank you! After talking to @julianrex, I'm going to take a different approach.

I'm still using the timer, but that is because I am not sure if there's another way to prevent the test from ending early.

jmkiley · 2019-05-21T00:55:59Z

It looks like MGLMapViewIntegrationTests already has some logic that I could reuse. I am going to expose -updateFromDisplayLink: and check for a delay of ~1 second.

jmkiley · 2019-06-03T20:15:23Z

I have rebased this on master and am almost ready for review. I am not sure if I should include platform/ios/ios.xcodeproj/xcshareddata/xcbaselines/ in this, or if that should be added to the .gitignore. @julianrex

jmkiley · 2019-06-06T21:27:11Z

platform/ios/ios.xcodeproj/project.pbxproj

@@ -2992,40 +3006,40 @@
 /* End PBXResourcesBuildPhase section */

 /* Begin PBXShellScriptBuildPhase section */
-		074A7F0B2277BD67001A62D1 /* Insert Mapbox Access Token */ = {
+		07796BA2227908CB0059CAF1 /* Insert Mapbox Access Token */ = {


to do: I should remove this script, it doesn't matter 😅

jmkiley · 2019-06-06T22:24:42Z

Currently these tests pass on Simulator, but fail on a physical iPhone X.

😅

julianrex · 2019-06-06T19:38:07Z

platform/ios/Integration Tests/MBXTestMapView.m

+@implementation MBXTestMapView
+
+- (void)updateFromDisplayLink:(CADisplayLink*)displayLink {
+    [super updateFromDisplayLink:displayLink];


At the moment this isn't doing anything. This is what we need to time, and we should assert if the time diff is >= 1 second.

julianrex · 2019-06-06T19:41:43Z

platform/ios/Integration Tests/MGLTabBarControllerTests.m

+    [self.window setRootViewController:(UITabBarController *)[storyboard instantiateViewControllerWithIdentifier:@"TabController"]];
+
+    // Access the tab controller from the story board, then access one of the childViewControllers.
+    self.tabController = (UITabBarController *)self.window.rootViewController;


I'd be tempted to set up tabController before you set the root view controller.

julianrex · 2019-06-06T19:42:18Z

platform/ios/Integration Tests/MGLTabBarControllerTests.m

+    self.tabController = (UITabBarController *)self.window.rootViewController;
+    self.viewController = self.tabController.childViewControllers[0];
+
+    [self.viewController.view addSubview:self.mapView];


We might need to look at the view sizes, and potentially the resizing masks/constraints.

julianrex · 2019-06-06T22:17:56Z

platform/ios/Integration Tests/MGLTabBarControllerTests.m

+    [self.mapView addAnnotation:annot];
+}
+
+- (void)testViewControllerNil {


Separate tests are completely new instances, so I think you could move this test into the main one below.

julianrex · 2019-06-06T22:20:46Z

platform/ios/Integration Tests/MGLTabBarControllerTests.m

+    XCTestExpectation *expectation = [self expectationWithDescription:@"Able to switch the tabs repeatedly without lag"];
+    __block NSInteger counter = 0;
+
+    __block NSTimer *repeatingTimer = [NSTimer scheduledTimerWithTimeInterval:0.1 repeats:YES block:^(NSTimer * _Nonnull timer) {


Let's pair on this block - not sure what we need to do here.

julianrex · 2019-06-06T22:24:04Z

platform/ios/Integration Tests/MGLTabBarControllerTests.m

+        counter++;
+        NSLog(@"%li", counter);
+        self.tabController.selectedIndex = counter % 2;
+        if (counter > 41) {


> 41? Is this a Douglas Adams reference??

julianrex · 2019-06-06T22:24:51Z

platform/ios/Integration Tests/MGLTabBarControllerTests.m

+            repeatingTimer = nil;
+
+            MGLMapCamera *camera = [MGLMapCamera cameraLookingAtCenterCoordinate:CLLocationCoordinate2DMake(10, 10) altitude:100 pitch:0 heading:0];
+            [self.mapView flyToCamera:camera withDuration:4 completionHandler:^{


I wonder if this should happen at the start of the timer?

julianrex · 2019-06-06T22:26:46Z

platform/ios/Integration Tests/MGLTabBarControllerTests.m

+                [expectation fulfill];
+            }];
+
+            [self measureBlock:^{


We shouldn't need to call updateFromDisplayLink the waitForExpectations:.. below should handle that IIRC.

I hadn't considered using measureBlock - that's an interesting idea - but I don't think it's appropriate here.

stale · 2019-08-14T01:16:49Z

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

stale · 2020-03-17T05:34:31Z

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

jmkiley added iOS Mapbox Maps SDK for iOS tests labels May 17, 2019

jmkiley self-assigned this May 17, 2019

jmkiley changed the base branch from master to release-nectar May 17, 2019 22:48

jmkiley commented May 17, 2019

View reviewed changes

friedbunny reviewed May 21, 2019

View reviewed changes

jmkiley added 10 commits June 3, 2019 11:21

[ios] it's a start

a55b762

[ios] added nadia's repro

abef73b

[ios] renamed file, added a window property to MGLMapViewIntegrationTest

91298c7

[ios] remove mapView property

6aac864

[ios] added map view subclass, access token run script

347b7cc

[ios] it'sadded measureblock, added suggestions from julian

41a7351

[ios] added animation

370b52f

[ios] added measureBlock, cleaned up file

1740cc3

[ios] Accidentally committed MGLMapSnapshotter

892be4b

[ios] Cleaned up tests

58ce1ec

jmkiley force-pushed the jmkiley-map-view-tests branch from 8506a76 to 58ce1ec Compare June 3, 2019 18:21

jmkiley changed the base branch from release-nectar to master June 3, 2019 18:21

jmkiley added 2 commits June 3, 2019 13:19

[ios] additional cleanup

dba39b3

[ios] added a few comments

5320125

jmkiley requested review from julianrex and friedbunny June 6, 2019 19:29

jmkiley marked this pull request as ready for review June 6, 2019 19:34

jmkiley requested a review from a team June 6, 2019 19:34

jmkiley commented Jun 6, 2019

View reviewed changes

julianrex reviewed Jun 6, 2019

View reviewed changes

[ios] start to breakup integration tests

6d87fec

[ios] play with the new file

e95492a

stale bot added the archived Archived because of inactivity label Aug 13, 2019

stale bot closed this Aug 14, 2019

friedbunny reopened this Aug 14, 2019

stale bot removed the archived Archived because of inactivity label Aug 14, 2019

friedbunny removed their request for review October 23, 2019 20:54

stale bot added the archived Archived because of inactivity label Mar 17, 2020

stale bot closed this Mar 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ios] Test map view within tab bar controller #14704

[ios] Test map view within tab bar controller #14704

jmkiley commented May 17, 2019

jmkiley May 17, 2019

friedbunny May 21, 2019

jmkiley May 21, 2019

jmkiley Jun 6, 2019

jmkiley commented May 21, 2019

jmkiley commented Jun 3, 2019

jmkiley Jun 6, 2019

jmkiley commented Jun 6, 2019

julianrex Jun 6, 2019

julianrex Jun 6, 2019

julianrex Jun 6, 2019

julianrex Jun 6, 2019

julianrex Jun 6, 2019

julianrex Jun 6, 2019

julianrex Jun 6, 2019

julianrex Jun 6, 2019

stale bot commented Aug 14, 2019

stale bot commented Mar 17, 2020

[ios] Test map view within tab bar controller #14704

[ios] Test map view within tab bar controller #14704

Conversation

jmkiley commented May 17, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmkiley commented May 21, 2019

jmkiley commented Jun 3, 2019

Choose a reason for hiding this comment

jmkiley commented Jun 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Aug 14, 2019

stale bot commented Mar 17, 2020