Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Add more cache management APIs #14925

Merged
merged 6 commits into from
Jun 18, 2019
Merged

[core] Add more cache management APIs #14925

merged 6 commits into from
Jun 18, 2019

Conversation

tmpsantos
Copy link
Contributor

  • API for resizing the ambient cache.
  • Make it possible to disable the ambient cache.
  • Performance benchmarks.
  • Fix tile deletion and invalidation not affecting resources that are not tiles.

julianrex
julianrex approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@julianrex julianrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tmpsantos tmpsantos self-assigned this Jun 14, 2019
@tmpsantos tmpsantos force-pushed the tmpsantos-cache_resize branch 3 times, most recently from 551699c to e3fdc03 Compare June 17, 2019 17:39
alexshalamov
alexshalamov approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits

benchmark/storage/offline_database.benchmark.cpp Outdated Show resolved Hide resolved
platform/default/src/mbgl/storage/default_file_source.cpp Outdated Show resolved Hide resolved
platform/default/src/mbgl/storage/default_file_source.cpp Outdated Show resolved Hide resolved
platform/default/src/mbgl/storage/default_file_source.cpp Outdated Show resolved Hide resolved
platform/default/src/mbgl/storage/offline_database.cpp Outdated Show resolved Hide resolved
@tmpsantos
[tests] Follow-up of previews PR, these tests need write permission
beeb7c9
@tmpsantos
[core] Rename resetCache to resetDatabase
a13280c 
Avoid confusion about what is being reset. In this case, the whole
database and not only the ambient cache.
@tmpsantos
[core] Clear/Invalidate should also work on non-tile resources
656e14b 
These methods were only affecting tiles, but they should really
work on every resource like style, glyphs, etc.
@tmpsantos
[core] Add method for setting a maximum size for the ambient cache
37b6abd 
- Removed this parameter from the constructor, now that we
  have a method to set it.
- Add the method and enforce the limits if the ambient cache exceeds the
  size.
@tmpsantos
[tests] Add unit tests for cache size
198eab4
@tmpsantos
[benchmark] Add benchmark tests for resizing the database
42afffb
@tmpsantos tmpsantos merged commit ffecb4d into master Jun 18, 2019
@tmpsantos tmpsantos deleted the tmpsantos-cache_resize branch June 18, 2019 13:26
@tobrun tobrun mentioned this pull request Jun 19, 2019
Merged
7 tasks
@friedbunny friedbunny mentioned this pull request Jun 19, 2019
Open
@chloekraw chloekraw mentioned this pull request Jun 28, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@julianrex julianrex julianrex approved these changes

@alexshalamov alexshalamov alexshalamov approved these changes

@tobrun tobrun Awaiting requested review from tobrun

@jmalanen jmalanen Awaiting requested review from jmalanen

Assignees

@tmpsantos tmpsantos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmpsantos @alexshalamov @julianrex