Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios, build] Add tests for MGLMapView pitch setting and tilt gesture #15028

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

friedbunny
Copy link
Contributor

@friedbunny friedbunny commented Jun 29, 2019

Part of #14091 — adds tests for MGLMapView pitch setting and for the tilt gesture recognizer.

  • Still a slight work in progress, as setting pitch to a negative value seems like it shouldn’t do anything, but currently results in a value of 60. Update: pitch is indeed not settable to negative values — it leaves the camera’s original value intact.
  • I may also add a test for [ios] Require two fingers for duration of tilt gesture #14969.

/cc @julianrex @fabian-guerra

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS tests UX labels Jun 29, 2019
@friedbunny friedbunny self-assigned this Jun 29, 2019
@friedbunny friedbunny added this to the release-picklejuice milestone Jul 1, 2019
@friedbunny friedbunny marked this pull request as ready for review July 2, 2019 21:40
@friedbunny friedbunny requested a review from a team July 2, 2019 21:40
@friedbunny
Copy link
Contributor Author

friedbunny commented Jul 2, 2019

@julianrex this is ready for review — I added more tests and split out others into their own test methods.

Copy link
Contributor

@julianrex julianrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a couple of comments/questions.

@friedbunny friedbunny force-pushed the friedbunny-adds-mglmapview-pitch-tests branch from df7f4ab to 322dce3 Compare July 8, 2019 23:25
@friedbunny friedbunny requested a review from julianrex July 8, 2019 23:36
Copy link
Contributor

@julianrex julianrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@friedbunny friedbunny merged commit d6c1c83 into master Jul 9, 2019
@friedbunny friedbunny deleted the friedbunny-adds-mglmapview-pitch-tests branch July 9, 2019 04:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS tests UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants